From nobody Mon Apr 6 17:32:52 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fqGcz6tx5z6YPN9; Mon, 06 Apr 2026 17:33:07 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4fqGcz1kk1z3GrH; Mon, 06 Apr 2026 17:33:07 +0000 (UTC) (envelope-from kib@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 636HWqLB034817; Mon, 6 Apr 2026 20:32:55 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 636HWqLB034817 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 636HWq9C034816; Mon, 6 Apr 2026 20:32:52 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Mon, 6 Apr 2026 20:32:52 +0300 From: Konstantin Belousov To: Dima Panov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3a01e1e1a50c - main - msun/aarch64: convert fenv functions to proper linkage Message-ID: References: <69caafbb.408c4.7b20a1e1@gitrepo.freebsd.org> <1f2ad4f0-a4ab-4f15-a779-5f1a6db9912b@FreeBSD.org> <8022afad-9cee-4ade-8b56-ef5b7feb6e16@FreeBSD.org> <31e15546-79b2-4109-998e-c5f981957044@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <31e15546-79b2-4109-998e-c5f981957044@FreeBSD.org> X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=4.0.2 X-Spam-Checker-Version: SpamAssassin 4.0.2 (2025-08-27) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4fqGcz1kk1z3GrH X-Spamd-Bar: ---- On Mon, Apr 06, 2026 at 08:25:02PM +0300, Dima Panov wrote: > > > On 06.04.2026 20:05, Konstantin Belousov wrote: > > diff --git a/lib/msun/arm/Makefile.inc b/lib/msun/arm/Makefile.inc > > index 6e3ddb351dd3..e155f1a2cae4 100644 > > --- a/lib/msun/arm/Makefile.inc > > +++ b/lib/msun/arm/Makefile.inc > > @@ -1,5 +1,4 @@ > > LDBL_PREC = 53 > > -SYM_MAPS += ${.CURDIR}/arm/Symbol.map > > Nope, amd64 is also have Symbol.map included in Makefile.inc > > --- a/lib/msun/aarch64/Makefile.inc > +++ b/lib/msun/aarch64/Makefile.inc > @@ -12,3 +12,5 @@ CFLAGS+=-DUSE_BUILTIN_FMIN > > CFLAGS+=-DUSE_BUILTIN_SQRTF > CFLAGS+=-DUSE_BUILTIN_SQRT > + > +SYM_MAPS += ${.CURDIR}/aarch64/Symbol.map > > and no need to patch msun/Makefile with additional checks/includes It can be done generically, so it is better to be done that way. The patch is preliminary anyway, I will do the pass over all arches.