Date: Wed, 11 Feb 2015 17:22:14 -0700 From: Warner Losh <imp@bsdimp.com> To: sbruno@freebsd.org Cc: freebsd-arm@freebsd.org Subject: Re: FreeBSD/arm64 MACHINE/MACHINE_ARCH identification Message-ID: <7CC61B0E-8630-4DB2-A4BC-8C22B33AAD77@bsdimp.com> In-Reply-To: <54DBAF15.60007@ignoranthack.me> References: <CAPyFy2A=Ev5gdYPKgEE0LS3-1sY%2BXmkZA7VCe71E6Fmbb=vMRw@mail.gmail.com> <54DB9D93.6070702@freebsd.org> <54DBAF15.60007@ignoranthack.me>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 11, 2015, at 12:35 PM, Sean Bruno <sbruno@ignoranthack.me> = wrote: >=20 > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 >=20 > On 02/11/15 10:21, Nathan Whitehorn wrote: >>=20 >> On 02/11/15 09:41, Ed Maste wrote: >>> The FreeBSD/arm64 work in progress currently reports "arm64" for >>> the machine and processor type - i.e., uname -m and uname -p. >>=20 >> It would probably also be good if we had MACHINE =3D arm here.=20 >> -Nathan >>=20 >=20 > TARGET=3Darm TARGET_ARCH=3Daarch64 is much more friendly to my qemu > universe as well. Is there going to be more than one TARGET_ARCH in > aarch64? Is there code shared between TARGET_ARCH=3Darmv6 and > TARGET_ARCH=3Daarch64? MACHINE_CPUARCH takes care of those issues. If the kernel is implemented in sys/arm, MACHINE should be arm. if it is = in sys/arm64, it should be arm64. The MACHINE type corresponds directly to where we = have the kernel files, and having something that=E2=80=99s MACHINE that=E2=80=99s = different than this is going to be an enormous pita in lots of places. Don=E2=80=99t do it :) Warner > sean >=20 >>> It seems that the official, awkward name aarch64 is broadly used=20 >>> elsewhere - for example, in toolchain triples and autoconf tests. >>> To save us grief in the future I think it is worth following >>> suit: >>>=20 >>> diff --git a/sys/arm64/include/param.h >>> b/sys/arm64/include/param.h index 5cd0445..525a0e7 100644 --- >>> a/sys/arm64/include/param.h +++ b/sys/arm64/include/param.h @@ >>> -43,10 +43,10 @@ #define STACKALIGN(p) ((uint64_t)(p) & >>> ~STACKALIGNBYTES) >>>=20 >>> #ifndef MACHINE -#define MACHINE "arm64" +#define >>> MACHINE "aarch64" #endif #ifndef MACHINE_ARCH -#define >>> MACHINE_ARCH "arm64" +#define MACHINE_ARCH >>> "aarch64" #endif >>>=20 >>=20 >=20 > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 >=20 > iQF8BAEBCgBmBQJU268TXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w > ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx > MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5ktS0IALDbc9d+ql6EoEU/NelZ7X27 > tS9oyXaGDBR6o2SU2v7NU5mZqwizsn4wzaLqwUbIOlrohlrAcHIW9A4yR98nUvxo > 5eCK+Vwv3ZqSD8EtnVkd7Y+Mr2RUlAG9i3+rHgBsyHhjp85uYK1xg8K3xrUqdHEU > GxALJReudIvrnCF4d05vyFYIUgqt7/1s17Ti4XE+Y1neOQlQ6Kmx9sXE0mEyah08 > 2mCCwQNjlSu5xOXzW0daMCtCo0AftPfD2ACwhw2ZQQIyLj8qwKVuChAfi5+Hdfy5 > TfV0SZmVbai11GCh3pOIQm6js3X21XIUiTSslVrn4745sN5cHHYZc/rQgoB3Lnw=3D > =3DjLJD > -----END PGP SIGNATURE----- > _______________________________________________ > freebsd-arm@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "freebsd-arm-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7CC61B0E-8630-4DB2-A4BC-8C22B33AAD77>