From nobody Thu Sep 7 15:09:12 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhN1x45dcz4rklq for ; Thu, 7 Sep 2023 15:09:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhN1x0f0wz4s3p for ; Thu, 7 Sep 2023 15:09:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-52bcd4db4e6so1457776a12.0 for ; Thu, 07 Sep 2023 08:09:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1694099363; x=1694704163; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/iVVSdk/TZQbwEVJO/ep2Q+pm2qz3FqJaJE0FKNR9DQ=; b=x8VbS5mM8jBRIzbvTiDCrsudvmBCaoAOnwlVIylqpK9IVxf3qWqBnPl+Qb9RUbaE3R eZYUK5QhhISpLvk6W0CS4Fo15wWTfHmpqhQD8+38d/StwqPz78MOxi1FXcjvipkhuz3o 7+sTwVHSzudf+LSbJidltLLsTbNkpuw0ssDLl/4N46Yk4mr+fEvyXCfyjkHFdq8DKM+G Jjmqkfrk1VqPC7C/l7qspGl3z4PNVIwWnbonyDBeLnQwIvHgZ8PmDB2elHKC6N7U8Mlq TizlrwRH6dEmbHGNdr+K0ppd8PSMydQh6pBn42b6MI5Qw9k9zBoTPFh59hKW5aC1D+fl pOMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694099363; x=1694704163; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/iVVSdk/TZQbwEVJO/ep2Q+pm2qz3FqJaJE0FKNR9DQ=; b=HK60DzO7ie8rZhX1ZGUIGFI/6CaLMDM+4Mwu+KQrDOoVdA+Okvcsn79Dlobbo+mOIj cXP+NS5FYRUwMTilEavrs2T6nxS5loNJiF/Q9GcfmQ6uIIRc/FYsVFY6mRD1DwGNcVBK pRCVBY8fjCLbgghsAzKsIipV49I3We02tAgs2/RPFRytX5t3lEQWEJdD5NCWG+otmYFM 42+1YZuSwDdOyS23syvgMRpgSKAUzcWUWmol5jDk9aYFwypPQJg4uUGuJhxRBTkJzDdv Np568Rkk7qpfQnUVIsCSELsawCw2Hchz9uVVTCphiw628YfZvGJh+jTZd389nyG/TUXY +MZA== X-Gm-Message-State: AOJu0YxZlQYvUh1953wGS/eqa5yCLT/nGgWGAhscJskrNgjA6Hr+9xjT YqQ30SxJa2sBppErGvQPabwnJM78DgfAyNc5X7Ji2Q== X-Google-Smtp-Source: AGHT+IGMzyNJnTAa+fHWHEYkjf0ub0aqotQMgTrbGFJ4sNTYfFl+baGK0c5QykxuIYQ6l4R0vQFJgvZdmSKgmg3+qvc= X-Received: by 2002:aa7:c859:0:b0:52c:e607:3866 with SMTP id g25-20020aa7c859000000b0052ce6073866mr4456725edt.32.1694099363470; Thu, 07 Sep 2023 08:09:23 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202309052116.385LGoau059784@gitrepo.freebsd.org> <92064p8n-134r-9rqo-8038-rpnq4r25p567@SerrOFQ.bet> <5325f22d-9e7f-04bd-ab35-128438eb9a2a@FreeBSD.org> <4sr8n9or-q731-1945-893s-no953r283756@SerrOFQ.bet> <5o323300-6053-0s28-692r-6oro7qq5n9p8@serrofq.bet> In-Reply-To: <5o323300-6053-0s28-692r-6oro7qq5n9p8@serrofq.bet> From: Warner Losh Date: Thu, 7 Sep 2023 09:09:12 -0600 Message-ID: Subject: Re: git: cf94672363d6 - main - rtw88/rtw89: remove local firmware. To: "Bjoern A. Zeeb" Cc: John Baldwin , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000c6372f0604c63e78" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4RhN1x0f0wz4s3p --000000000000c6372f0604c63e78 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 7, 2023, 7:45 AM Bjoern A. Zeeb wrote: > On Thu, 7 Sep 2023, Warner Losh wrote: > > > On Thu, Sep 7, 2023 at 6:36=E2=80=AFAM Bjoern A. Zeeb = wrote: > > > >> On Wed, 6 Sep 2023, John Baldwin wrote: > >> > >>> On 9/6/23 12:06 PM, Bjoern A. Zeeb wrote: > >>>> On Wed, 6 Sep 2023, John Baldwin wrote: > >>>> > >>>>> On 9/5/23 2:16 PM, Bjoern A. Zeeb wrote: > >>>>>> The branch main has been updated by bz: > >>>>>> > >>>>>> URL: > >>>>>> > >> > https://cgit.FreeBSD.org/src/commit/?id=3Dcf94672363d6638b7268c05b4628b62= bbfc8dbe5 > >>>>>> > >>>>>> commit cf94672363d6638b7268c05b4628b62bbfc8dbe5 > >>>>>> Author: Bjoern A. Zeeb > >>>>>> AuthorDate: 2023-06-08 21:35:09 +0000 > >>>>>> Commit: Bjoern A. Zeeb > >>>>>> CommitDate: 2023-09-05 21:13:18 +0000 > >>>>>> > >>>>>> rtw88/rtw89: remove local firmware. > >>>>>> Remove firmware from src/ in favor of the ports/package= s > >> and > >>>>>> fwget(8). > >>>>>> This will allow us to shrink the size of src (and installed > >>>>>> modules). > >>>>>> Update the rtw88 man page to reflect the change. > >>>>> > >>>>> How does this interfact with doing an install to a machine over one > of > >>>>> these > >>>>> interfaces? > >>>> > >>>> That's nothing we support. At least we do not support netboot over > wifi > >>>> currently, so you'll always need another install media. > >>>> > >>>> How's the "bootstrapping" going to work if wireless is the only > network > >>>> option? > >>> > >>> To be clear, I was discussing the case you use a USB memstick, but > fetch > >>> the base system and packages over the network. > >> > >> Understood. Not sure we actually support the former; I guess I am no= t > >> using the installer too much. > >> > >> > >>> Or at least you need to > >>> install pkg over the network, but you need pkg to install the firmwar= e > >>> so you can bring up the network which you did address, though it seem= s > >>> something we plan to fix in the future so won't be in 14.0? > >> > >> Yes. We plan to sort this out but I'd say it's unlikely for 14.0. > >> > >> And to be clear, it was me who raised exactly these "botstrapping" > >> installer concerns in the first place. > >> > >> At the moment we will first need stable drivers to be able to do any > >> networking in first place. Once that is sorted, installing mobile > >> devices with just them and no other means of networking will be > >> addressed. > >> > > > > Yea, the rtw88 driver is stable enough for me to do a network install > > over it. So now people with -current can't do that any more and have > > to do hokey things to get the firmware or other packages to the laptop > > before they can do anything. This is not really going to make people > > happy and will generate a fair number of complaints. > > > > I'd assume some other "fallout" will improve some installer bits along > >> when this happens and that we'll want enough and brought testing for i= t. > >> > > > > It sounds rather premature to remove it from -current if there's no > support > > in the installer, and nothing in place that adds the packages to the > > installation > > media with no firm plans or timelines to address that. > > You do understand that I also disconnected rtw88 from main? > > Please read the announcement and/or fill the gap. It is no less premature. It's the first step without a clear timeline. You've removed functionality that was present and my point is still valid. It's even worse because now I have to add this driver back when I upgrade my laptop or I have to find the USB dongle I was using. This just doesn't make any sense to me. Warner /bz > > -- > Bjoern A. Zeeb r15:7 --000000000000c6372f0604c63e78 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Sep 7, 2023, 7:45 AM Bjoern A. Zeeb <bz@freebsd.org> wrote:
On Thu, 7 Sep 2023, Warner Losh wrote:

> On Thu, Sep 7, 2023 at 6:36=E2=80=AFAM Bjoern A. Zeeb <bz@freebsd.org> wrote:
>
>> On Wed, 6 Sep 2023, John Baldwin wrote:
>>
>>> On 9/6/23 12:06 PM, Bjoern A. Zeeb wrote:
>>>> On Wed, 6 Sep 2023, John Baldwin wrote:
>>>>
>>>>> On 9/5/23 2:16 PM, Bjoern A. Zeeb wrote:
>>>>>> The branch main has been updated by bz:
>>>>>>
>>>>>> URL:
>>>>>>
>> https://cgit.FreeBSD.org/src/commit/?id=3Dcf94672363d6638b7268c05b4628b62= bbfc8dbe5
>>>>>>
>>>>>> commit cf94672363d6638b7268c05b4628b62bbfc8dbe5 >>>>>> Author:=C2=A0 =C2=A0 =C2=A0Bjoern A. Zeeb <bz@F= reeBSD.org>
>>>>>> AuthorDate: 2023-06-08 21:35:09 +0000
>>>>>> Commit:=C2=A0 =C2=A0 =C2=A0Bjoern A. Zeeb <bz@F= reeBSD.org>
>>>>>> CommitDate: 2023-09-05 21:13:18 +0000
>>>>>>
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0rtw88/rtw89: remove loca= l firmware.
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Remove fi= rmware from src/ in favor of the ports/packages
>> and
>>>>>> fwget(8).
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0This will allow us to sh= rink the size of src (and installed
>>>>>> modules).
>>>>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0Update the rtw88 man pag= e to reflect the change.
>>>>>
>>>>> How does this interfact with doing an install to a mac= hine over one of
>>>>> these
>>>>> interfaces?
>>>>
>>>> That's nothing we support.=C2=A0 At least we do not su= pport netboot over wifi
>>>> currently, so you'll always need another install media= .
>>>>
>>>> How's the "bootstrapping" going to work if w= ireless is the only network
>>>> option?
>>>
>>> To be clear, I was discussing the case you use a USB memstick,= but fetch
>>> the base system and packages over the network.
>>
>> Understood.=C2=A0 Not sure we actually support the former;=C2=A0 I= guess I am not
>> using the installer too much.
>>
>>
>>> Or at least you need to
>>> install pkg over the network, but you need pkg to install the = firmware
>>> so you can bring up the network which you did address, though = it seems
>>> something we plan to fix in the future so won't be in 14.0= ?
>>
>> Yes.=C2=A0 We plan to sort this out but I'd say it's unlik= ely for 14.0.
>>
>> And to be clear, it was me who raised exactly these "botstrap= ping"
>> installer concerns in the first place.
>>
>> At the moment we will first need stable drivers to be able to do a= ny
>> networking in first place.=C2=A0 =C2=A0Once that is sorted, instal= ling mobile
>> devices with just them and no other means of networking will be >> addressed.
>>
>
> Yea, the rtw88 driver is stable enough for me to do a network install<= br> > over it. So now people with -current can't do that any more and ha= ve
> to do hokey things to get the firmware or other packages to the laptop=
> before they can do anything. This is not really going to make people > happy and will generate a fair number of complaints.
>
> I'd assume some other "fallout" will improve some instal= ler bits along
>> when this happens and that we'll want enough and brought testi= ng for it.
>>
>
> It sounds rather premature to remove it from -current if there's n= o support
> in the installer, and nothing in place that adds the packages to the > installation
> media with no firm plans or timelines to address that.

You do understand that I also disconnected rtw88 from main?

Please read the announcement and/or fill the gap.
<= div dir=3D"auto">
It is no less premature. It= 9;s the first step without a clear timeline. You've removed functionali= ty that was present and my point is still valid.
It's even worse because now I have to add this= driver back when I upgrade my laptop or I have to find the USB dongle I wa= s using.

This just doesn= 't make any sense to me.

Warner


/bz

--
Bjoern A. Zeeb=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0r15:7
--000000000000c6372f0604c63e78--