Date: Sat, 19 Nov 2005 08:40:25 GMT From: "Vladimir V. Pavluk" <vvp@dgs.ru> To: freebsd-multimedia@FreeBSD.org Subject: Re: kern/89046: [sound] [patch] pchan-related sound corruption in ESS Allegro-1 (snd_maestro3) Message-ID: <200511190840.jAJ8eP2h078675@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/89046; it has been noted by GNATS.
From: "Vladimir V. Pavluk" <vvp@dgs.ru>
To: bug-followup@freebsd.org, vvp@dgs.ru
Cc:
Subject: Re: kern/89046: [sound] [patch] pchan-related sound corruption in ESS Allegro-1 (snd_maestro3)
Date: Sat, 19 Nov 2005 04:10:23 +0600
I've fixed previous ugly patch for maestro3. Now driver drains play channel
only if none of channels is active.
--- maestro3.c.orig Mon Nov 14 18:11:09 2005
+++ maestro3.c Sat Nov 19 04:02:38 2005
@@ -574,8 +574,11 @@
/* XXX should the channel be drained? */
/*[[dec_timer_users]]*/
- m3_wr_assp_data(sc, KDATA_TIMER_COUNT_RELOAD, 0);
- m3_wr_assp_data(sc, KDATA_TIMER_COUNT_CURRENT, 0);
+ if(!sc->pch_active_cnt) {
+ m3_wr_assp_data(sc, KDATA_TIMER_COUNT_RELOAD, 0);
+ m3_wr_assp_data(sc, KDATA_TIMER_COUNT_CURRENT, 0);
+ }
+
data = m3_rd_2(sc, HOST_INT_CTRL);
m3_wr_2(sc, HOST_INT_CTRL, data & ~CLKRUN_GEN_ENABLE);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200511190840.jAJ8eP2h078675>