From owner-svn-src-head@freebsd.org Sat Sep 26 14:19:11 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31B1FA0972B for ; Sat, 26 Sep 2015 14:19:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-f46.google.com (mail-qg0-f46.google.com [209.85.192.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E5CABF84 for ; Sat, 26 Sep 2015 14:19:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qgev79 with SMTP id v79so90169203qge.0 for ; Sat, 26 Sep 2015 07:19:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RIQYKexy4ibo2hLlmLDdS67wYT12rqC41P13DYQqZ4c=; b=C0Q04OyLIfjO9RnnOtn+A/uReJWYdBBDOoCHwk1XGJWI3Bc5DqOjHUFSe9+44/bqTd ftIw+OrQ9ly2RHaw8FFM0ayvhx9GtmYYqEMTKKQRRrc+gLC5IAk473qdgPkFbW1F1FAF zF7Lz566rkKsCa/vFxYb1FZUzaA/8em28JoHYRnq0qXv4Hwo+cULeCl5DyBt42DHUN2a xTVrQSwE7h87OUTPbGt07bEO/1nDdo9/eP1xkujZkrxWgyIZ/8ionuA8ybjQoBZk4q4D 8IXMdnrr7sgdZRzcIJKCWIzyXjbyncTahT7lnf9WfDIrFACnfgQOm1n9RMSItF8v8W05 EY3g== X-Gm-Message-State: ALoCoQkQIZwXSyWoSmxh+xz5oHDjavtEqxUMTRYnd+LC3F9TRc3dyGjU1o3GftjIkimHHQ9gFOUU MIME-Version: 1.0 X-Received: by 10.140.96.200 with SMTP id k66mr12035324qge.81.1443277149131; Sat, 26 Sep 2015 07:19:09 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.140.80.167 with HTTP; Sat, 26 Sep 2015 07:19:09 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: References: <201509252303.t8PN3Wx0098623@repo.freebsd.org> <5605D4FC.4040205@FreeBSD.org> Date: Sat, 26 Sep 2015 08:19:09 -0600 X-Google-Sender-Auth: a99OKE276OJ0F_oZWSRu2XqyBBc Message-ID: Subject: Re: svn commit: r288241 - head/share/mk From: Warner Losh To: NGie Cooper Cc: Bryan Drewery , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Sep 2015 14:19:11 -0000 On Fri, Sep 25, 2015 at 11:11 PM, NGie Cooper wrote: > On Fri, Sep 25, 2015 at 4:13 PM, Bryan Drewery > wrote: > > On 9/25/2015 4:12 PM, NGie Cooper wrote: > >> On Fri, Sep 25, 2015 at 4:03 PM, Bryan Drewery > wrote: > >>> Author: bdrewery > >>> Date: Fri Sep 25 23:03:32 2015 > >>> New Revision: 288241 > >>> URL: https://svnweb.freebsd.org/changeset/base/288241 > >>> > >>> Log: > >>> Remove 'set -e' that are no longer needed as it is already default. > >>> > >>> When bmake was initially imported at r241298 shell commands were no > longer > >>> ran with 'set -e' as they were before. This was fixed in r254980 so > they > >>> again always use 'set -e'. > >> > >> The bsd.subdir.mk portion of the change looks like it would cause > >> issues depending on what's being called (fmake or an earlier version > >> of sys.mk might be used at install time). > >> > > > > We only support bmake in head. And the 'set -e' were only added for > > bmake compatibility before it was fixed to work like fmake did. > > Sorry. Fuzzy memory on the latter item. Yeah, I requested it a couple > years ago. > > We might only support bmake in head, but there's nothing preventing > someone from doing a source upgrade from one of the older 10 releases > to 11+. Thinking about this a bit more, this is an extreme edge case > that doesn't really matter, because people doing source upgrades > across major releases really should be doing them from the latest > minor release for the major release > I wouldn't state it so glibly. It is not as extreme as you might think. For a long time compiling -current from a host that was one or two major releases old has worked. Currently we advertise that we can upgrade from the stable/9 branch point or newer to tip of head (based on values in Makefile.inc1). I don't believe that Bryan's change set changes that in any significant way, but given the large amount of churn he and I (and others) have generated in /usr/share/mk, testing from a 9.x machine would be prudent. I didn't remove some minor bits of code, and also made sys.mk compatible with the FreeBSD 9 fmake because of issues like this. Warner