From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 10 17:30:02 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 58D65D3A for ; Sun, 10 Nov 2013 17:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 456492680 for ; Sun, 10 Nov 2013 17:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id rAAHU2Rf000193 for ; Sun, 10 Nov 2013 17:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id rAAHU1jl000192; Sun, 10 Nov 2013 17:30:01 GMT (envelope-from gnats) Date: Sun, 10 Nov 2013 17:30:01 GMT Message-Id: <201311101730.rAAHU1jl000192@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: dfilter@FreeBSD.ORG (dfilter service) Subject: Re: ports/183718: commit references a PR X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: dfilter service List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Nov 2013 17:30:02 -0000 The following reply was made to PR ports/183718; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/183718: commit references a PR Date: Sun, 10 Nov 2013 17:27:25 +0000 (UTC) Author: rakuco Date: Sun Nov 10 17:27:16 2013 New Revision: 333411 URL: http://svnweb.freebsd.org/changeset/ports/333411 Log: - Support staging, which allows us to simplify the Makefile a bit. - Fix a regression introduced in r297435 (ports/167611) that hardcoded wcslib.pc's installation path and rendered the sed call in the post-patch target useless. This broke automated builds in things like Poudriere. PR: ports/183718 Submitted by: rakuco@ Approved by: Tony Maher (maintainer) Modified: head/astro/wcslib/Makefile head/astro/wcslib/files/patch-GNUmakefile head/astro/wcslib/pkg-plist Modified: head/astro/wcslib/Makefile ============================================================================== --- head/astro/wcslib/Makefile Sun Nov 10 16:57:25 2013 (r333410) +++ head/astro/wcslib/Makefile Sun Nov 10 17:27:16 2013 (r333411) @@ -9,7 +9,6 @@ MASTER_SITES= ftp://ftp.atnf.csiro.au/pu MAINTAINER= tonymaher@optusnet.com.au COMMENT= Library for parsing/generating FITS headers -NO_STAGE= yes USE_BZIP2= yes GNU_CONFIGURE= yes USES= gmake @@ -17,7 +16,6 @@ MAKEFILE= GNUmakefile USE_LDCONFIG= yes PLIST_SUB= VERSION="${PORTVERSION}" -MAN1= fitshdr.1 # See makedefs.in which describes why you want to set the extra support. # For most users it will not be required. @@ -43,15 +41,13 @@ LIB_DEPENDS+= pgplot.5:${PORTSDIR}/graph .endif post-patch: - @${REINPLACE_CMD} -e 's#%%PKGDIR%%#${LOCALBASE}/libdata#g' \ + @${REINPLACE_CMD} -e 's#%%PKGDIR%%#${STAGEDIR}${PREFIX}/libdata#g' \ ${WRKSRC}/GNUmakefile post-install: -.if ${PORT_OPTIONS:MDOCS} - @${MKDIR} ${DOCSDIR} - (cd ${WRKSRC}/ && ${INSTALL_DATA} CHANGES README COPYING COPYING.LESSER wcslib.pdf ${DOCSDIR}) - @${MKDIR} ${DOCSDIR}/html - (cd ${WRKSRC}/html && ${INSTALL_DATA} * ${DOCSDIR}/html) -.endif + ${MKDIR} ${STAGEDIR}${DOCSDIR} + (cd ${WRKSRC}/ && ${INSTALL_DATA} CHANGES README COPYING COPYING.LESSER wcslib.pdf ${STAGEDIR}${DOCSDIR}) + ${MKDIR} ${STAGEDIR}${DOCSDIR}/html + (cd ${WRKSRC}/html && ${INSTALL_DATA} * ${STAGEDIR}${DOCSDIR}/html) .include Modified: head/astro/wcslib/files/patch-GNUmakefile ============================================================================== --- head/astro/wcslib/files/patch-GNUmakefile Sun Nov 10 16:57:25 2013 (r333410) +++ head/astro/wcslib/files/patch-GNUmakefile Sun Nov 10 17:27:16 2013 (r333411) @@ -22,11 +22,11 @@ - $(INSTALL) -m 444 html/* $(HTMLDIR)/html - if [ ! -d "$(LIBDIR)/pkgconfig" ] ; then \ - $(INSTALL) -d -m 2775 $(LIBDIR)/pkgconfig ; \ -+ if [ ! -d "/usr/local/libdata/pkgconfig" ] ; then \ -+ $(INSTALL) -d -m 2775 /usr/local/libdata/pkgconfig ; \ ++ if [ ! -d "%%PKGDIR%%/pkgconfig" ] ; then \ ++ $(INSTALL) -d -m 2775 %%PKGDIR%%/pkgconfig ; \ fi - $(INSTALL) -m 444 wcslib.pc $(LIBDIR)/pkgconfig/wcslib.pc -+ $(INSTALL) -m 444 wcslib.pc /usr/local/libdata/pkgconfig/wcslib.pc ++ $(INSTALL) -m 444 wcslib.pc %%PKGDIR%%/pkgconfig/wcslib.pc clean cleaner : for DIR in $(SUBDIRS) doxygen ; do \ Modified: head/astro/wcslib/pkg-plist ============================================================================== --- head/astro/wcslib/pkg-plist Sun Nov 10 16:57:25 2013 (r333410) +++ head/astro/wcslib/pkg-plist Sun Nov 10 17:27:16 2013 (r333411) @@ -29,6 +29,7 @@ lib/libwcs.so lib/libwcs.so.%%VERSION%% lib/libwcs.so.4 libdata/pkgconfig/wcslib.pc +man/man1/fitshdr.1.gz %%PORTDOCS%%%%DOCSDIR%%/html/functions_0x73.html %%PORTDOCS%%%%DOCSDIR%%/html/functions_vars_0x62.html %%PORTDOCS%%%%DOCSDIR%%/html/wcshdr_8h-source.html _______________________________________________ svn-ports-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-ports-all To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"