From owner-cvs-all@FreeBSD.ORG  Wed Apr 21 17:21:43 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 680)
	id 54C9D16A4CF; Wed, 21 Apr 2004 17:21:43 -0700 (PDT)
Date: Wed, 21 Apr 2004 17:21:43 -0700
From: Darren Reed <darrenr@hub.freebsd.org>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
Message-ID: <20040422002143.GC60368@hub.freebsd.org>
References: <200404211527.i3LFRabS088245@repoman.freebsd.org>
	<20040421232445.GB60368@hub.freebsd.org>
	<6.0.1.1.1.20040422005919.03afaaa0@imap.sfu.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6.0.1.1.1.20040422005919.03afaaa0@imap.sfu.ca>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: Luigi Rizzo <luigi@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net radix.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 00:21:43 -0000

On Thu, Apr 22, 2004 at 01:03:42AM +0100, Colin Percival wrote:
> At 00:24 22/04/2004, Darren Reed wrote:
> >Some of these changes, for the sake of change, can be annoying...
> 
>   As Luigi mentioned when he started this, these aren't changes "for the
> sake of change"; rather, these are changes to clean things up so that it
> is easier to add all the necessary locking.

Uh, really?
Changing variable names is required to make locking easier?
Changing "x = *(u_char *)p" into "x = LEN(p)" makes locking easier?

In the end, if someone decides that the code needs to be restructured
for better performance in SMP hardware, then that's what'll happen and
changes like these will have little significance at that point in time.

Darren