From owner-svn-src-head@freebsd.org Thu Dec 13 06:07:51 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDE23130AC4F; Thu, 13 Dec 2018 06:07:50 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 644116FA67; Thu, 13 Dec 2018 06:07:50 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B270421F51; Thu, 13 Dec 2018 01:07:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 13 Dec 2018 01:07:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=g yRlVeE7ZYZ3MXc7caIWlBSdzcp+2+IX5kSpekFwDOo=; b=VYVq5wDk/e7xm0lmK vDXQMx306qAAVqEp8vVnfPKHh2efyeiTJibMW2PplRrVIpjF2w/1Rdqqy/KszbSK laJEmx0qm2TxqCJkpTB/Xcn6j1mjltmXptCNTD/07vyOpbkmULi42aSU6phTm0XZ BoyTaTG0iCasIONwmeAu+ZaDB0PVgIhJQqfBv0LbTgmNxNBAVL3xvS8Y7WJi9y4F dWt3SnR0AC7uQtjgt2fGZgnEx6zmAcvsuEpYOU33b+qzc6lxnuh+PZp8b6URzgzJ UjYofarxXxRSW07uFqRSSXoi00P4TCgxmpsfm1+G/i5Pjyt2WlH+4Jym/18jrQzh sO3Mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=gyRlVeE7ZYZ3MXc7caIWlBSdzcp+2+IX5kSpekFwD Oo=; b=vKGjqsSdlPqcAb102Zrv/tijIAMAvtAX24D7nEJS4dHMhjxhUTw1OXT3Y 4gIXH/4MwbyFzUlJExNa1lC1DEEYeaAwHyFgxOC7Ivt36PxJEma8fIPE19cr/4dV vbohuMH0QuJ/bEstg2OYuseSlk2NdHt09A8ynO/XbMi/F4gM4kI9XsEyIiOmHdRi Ok/ppUi+RB3Eea7PAfKMidvS5EHZe6W1i7YnMnpPXg4tP2abI4DKoTWpH6+X/a8I ygFU3GTDyL1mOWK5nJbNrM55saMNmlpLOsjLIxiSDwmcCThb2WLnNlF0hIxKiC2q fpTWCjoxq62O57KTSlQdCEmpxmXTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehuddgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkff gfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpegjuhhrihcurfgrnhhkohhvuceohihu rhhiphhvseihuhhrihhpvhdrnhgvtheqnecuffhomhgrihhnpehfrhgvvggsshgurdhorh hgpdgtrhihphhtohguvghvqdhlihhnuhigrdhorhhgpdhgihhthhhusgdrtghomhenucfk phepkeefrddvfeelrdegfedrudeinecurfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrih hpvheshihurhhiphhvrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from odin.yuripv.net (unknown [83.239.43.16]) by mail.messagingengine.com (Postfix) with ESMTPA id 69F21E4122; Thu, 13 Dec 2018 01:07:48 -0500 (EST) Subject: Re: svn commit: r342009 - head/secure/lib/libcrypto To: Jung-uk Kim , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201812122156.wBCLum13004450@repo.freebsd.org> From: Yuri Pankov Message-ID: <859a37f9-504d-0f31-86f9-5083d16306b1@yuripv.net> Date: Thu, 13 Dec 2018 09:07:46 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <201812122156.wBCLum13004450@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 644116FA67 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-5.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.96)[-0.965,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 06:07:51 -0000 Jung-uk Kim wrote: > Author: jkim > Date: Wed Dec 12 21:56:47 2018 > New Revision: 342009 > URL: https://svnweb.freebsd.org/changeset/base/342009 > > Log: > Enable devcryptoeng for OpenSSL. > > Since OpenSSL 1.1.1, the good old BSD-specific cryptodev engine has been > deprecated in favor of this new engine. However, this engine is not > throughly tested on FreeBSD because it was originally written for Linux. > > http://cryptodev-linux.org/ > > Also, the author actually meant to enable it by default on BSD platforms but > he failed to do so because there was a bug in the Configure script. > > https://github.com/openssl/openssl/pull/7882 > > Now they found that it was more generic issue. > > https://github.com/openssl/openssl/pull/7885 > > Therefore, we need to enable this engine on head to give it more exposure. > > Modified: > head/secure/lib/libcrypto/Makefile > head/secure/lib/libcrypto/opensslconf.h.in > > Modified: head/secure/lib/libcrypto/Makefile > ============================================================================== > --- head/secure/lib/libcrypto/Makefile Wed Dec 12 21:56:45 2018 (r342008) > +++ head/secure/lib/libcrypto/Makefile Wed Dec 12 21:56:47 2018 (r342009) > @@ -192,8 +192,8 @@ SRCS+= ecp_nistz256-x86.S ecp_nistz256.c > .endif > > # engine > -SRCS+= eng_all.c eng_cnf.c eng_ctrl.c eng_dyn.c eng_err.c eng_fat.c > -SRCS+= eng_init.c eng_lib.c eng_list.c eng_openssl.c eng_pkey.c > +SRCS+= eng_all.c eng_cnf.c eng_ctrl.c eng_devcrypto.c eng_dyn.c eng_err.c > +SRCS+= eng_fat.c eng_init.c eng_lib.c eng_list.c eng_openssl.c eng_pkey.c > SRCS+= eng_rdrand.c eng_table.c tb_asnmth.c tb_cipher.c tb_dh.c tb_digest.c > SRCS+= tb_dsa.c tb_eckey.c tb_pkmeth.c tb_rand.c tb_rsa.c > > > Modified: head/secure/lib/libcrypto/opensslconf.h.in > ============================================================================== > --- head/secure/lib/libcrypto/opensslconf.h.in Wed Dec 12 21:56:45 2018 (r342008) > +++ head/secure/lib/libcrypto/opensslconf.h.in Wed Dec 12 21:56:47 2018 (r342009) > @@ -46,9 +46,6 @@ extern "C" { > #ifndef OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE > # define OPENSSL_NO_CRYPTO_MDEBUG_BACKTRACE > #endif > -#ifndef OPENSSL_NO_DEVCRYPTOENG > -# define OPENSSL_NO_DEVCRYPTOENG > -#endif > #ifndef OPENSSL_NO_EC_NISTP_64_GCC_128 > # define OPENSSL_NO_EC_NISTP_64_GCC_128 > #endif I'm now getting "Could not open /dev/crypto: No such file or directory" from every other utility unless cryptodev is loaded; given that it's not in GENERIC, this is somewhat unexpected change in behavior.