From owner-freebsd-current@FreeBSD.ORG Mon Oct 27 22:47:34 2014 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F273A337; Mon, 27 Oct 2014 22:47:33 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B32CBF90; Mon, 27 Oct 2014 22:47:33 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s9RMlW16076294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 27 Oct 2014 15:47:32 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s9RMlWXQ076293; Mon, 27 Oct 2014 15:47:32 -0700 (PDT) (envelope-from jmg) Date: Mon, 27 Oct 2014 15:47:32 -0700 From: John-Mark Gurney To: Brooks Davis Subject: Re: issues w/ installing stuff multiple times... Message-ID: <20141027224732.GP82214@funkthat.com> Mail-Followup-To: Brooks Davis , Garrett Cooper , "freebsd-testing@FreeBSD.org" , "current@FreeBSD.org" References: <20141027215058.GN82214@funkthat.com> <20141027221048.GF59119@spindle.one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141027221048.GF59119@spindle.one-eyed-alien.net> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Mon, 27 Oct 2014 15:47:32 -0700 (PDT) Cc: "freebsd-testing@FreeBSD.org" , "current@FreeBSD.org" , Garrett Cooper X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2014 22:47:34 -0000 Brooks Davis wrote this message on Mon, Oct 27, 2014 at 22:10 +0000: > On Mon, Oct 27, 2014 at 02:55:09PM -0700, Garrett Cooper wrote: > > > > > On Oct 27, 2014, at 14:50, John-Mark Gurney wrote: > > > > > > There are issues w/ installing tests where the test files get installed > > > multiple times. > > > > > > To reproduce this, use the following steps: > > > make installworld -j 8 DESTDIR= -DNO_ROOT > > > > > > Once you have done the above, in there will be the file > > > METALOG, run: > > > grep -v type=dir /METALOG | awk '{ print $1 }' | sort | uniq -d > > > > > > This will print out the current list if files that get installed multiple > > > times.... > > > > > > Currently, it looks like all the tests subdirs are installed a second > > > time... > > > > > > Could someone look at making it so that they don't get installed > > > multiple times? > > > > Hi jmg! > > I have a patch out for this that I need to commit today. Thank you for the reminder. > > Great to hear this will be fixed. Once we've fixed them all, it would be > really good to have a test in Jenkins looking out for new duplicate files > since they are always bugs. I agree.... I've given the meat of the test above... Any output from that pipeline means that there is a bug... Also, it'd be good if Jenkins would do an installworld in addition to a buildworld... We've recently had breakages that are only uncovered when installworld is done... Current items (other than tests) installed multiple times: /etc/mail/mailer.conf /usr/libdata/pkgconfig/* various man pages: nvlist_freef, various loader So, shouldn't be too much work to knock the rest out... If someone adds the jenkins test, I'll fix the remaining issues (others are free to fix these too)... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."