From owner-freebsd-xen@FreeBSD.ORG Tue Dec 24 15:51:15 2013 Return-Path: Delivered-To: freebsd-xen@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 74376DBD; Tue, 24 Dec 2013 15:51:15 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4A33B1AD6; Tue, 24 Dec 2013 15:51:15 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5064CB9A3; Tue, 24 Dec 2013 10:51:14 -0500 (EST) From: John Baldwin To: Roger Pau Monne Subject: Re: [PATCH v7 15/19] xen: create a Xen nexus to use in PV/PVH Date: Tue, 24 Dec 2013 10:39:30 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <1387479296-33389-1-git-send-email-roger.pau@citrix.com> <1387479296-33389-16-git-send-email-roger.pau@citrix.com> In-Reply-To: <1387479296-33389-16-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201312241039.30656.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 24 Dec 2013 10:51:14 -0500 (EST) Cc: xen-devel@lists.xen.org, julien.grall@citrix.com, freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org, gibbs@freebsd.org X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Dec 2013 15:51:15 -0000 On Thursday, December 19, 2013 1:54:52 pm Roger Pau Monne wrote: > Introduce a Xen specific nexus that is going to be in charge for > attaching Xen specific devices. Remove the identify routine from Xen > devices and instead attach them from the nexus (PV/PVH) or xenpci > (HVM). As with my previous mail, I would encourage you to create a xenpv0 device and have the xen nexus be very minimal. This would let you leave the existing identify routines in place (which is cleaner / more extensible than a static table of devices that you explicitly add), but by having the PV-specific drivers attach as children of xenpv0, their identify routines would only be invoked when xenpv0 attached. You can even use an identify routine for CPUs (see cpu_identify in sys/x86/x86/legacy.c). -- John Baldwin