From owner-freebsd-arch@FreeBSD.ORG  Mon Dec  4 21:51:38 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4193216A7ED;
	Mon,  4 Dec 2006 21:51:38 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3EBDE447BB;
	Mon,  4 Dec 2006 21:38:03 +0000 (GMT) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id kB4LcGMV059694
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 4 Dec 2006 13:38:17 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <45749548.8010208@errno.com>
Date: Mon, 04 Dec 2006 13:38:16 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.7 (X11/20060920)
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <45746791.5040807@errno.com> <200612041610.14195.jhb@freebsd.org>
In-Reply-To: <200612041610.14195.jhb@freebsd.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-arch@freebsd.org
Subject: Re: CFR: NFS root options fixup
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2006 21:51:38 -0000

John Baldwin wrote:
> On Monday 04 December 2006 13:23, Sam Leffler wrote:
>> There's a small patch at:
>>
>> http://www.freebsd.org/~sam/nfsopts.patch
>>
>> to unify parsing of nfs mount options supplied when booting over the
>> net.  It also extends the supported options so you can do things like
>> specify nolockd, tcp, udp, and nfsv2, nfsv3.  Some of this appears to be
>> superfluous given the work that rc.initdiskless does but it's there.
>>
>> The one change I'm uncertain of is the bounds checking I apply to
>> rsize/wsize.
>>
>> 	Sam
> 
> Do you need to set NFSMNT_RSIZE and NFSMNT_WSIZE in nd->flags in
> nfs_parse_options() if you get a "rsize" or "wsize" option?  For the
> bootp case the flags are always set, but was worried about the
> non-bootp case.
> 

Probably.  I have not had time to test the pxe booting case.  I've only
tested booting with bootp/dhcp.

	Sam