From owner-freebsd-ppc@FreeBSD.ORG Tue Oct 15 03:40:01 2013 Return-Path: Delivered-To: freebsd-ppc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B196BC33 for ; Tue, 15 Oct 2013 03:40:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9E6032C34 for ; Tue, 15 Oct 2013 03:40:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9F3e1bw061889 for ; Tue, 15 Oct 2013 03:40:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9F3e1IY061888; Tue, 15 Oct 2013 03:40:01 GMT (envelope-from gnats) Date: Tue, 15 Oct 2013 03:40:01 GMT Message-Id: <201310150340.r9F3e1IY061888@freefall.freebsd.org> To: freebsd-ppc@FreeBSD.org Cc: From: Julio Merino Subject: Re: powerpc/182978: Kernel panic on boot on powerpc64 X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Julio Merino List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 03:40:01 -0000 The following reply was made to PR powerpc/182978; it has been noted by GNATS. From: Julio Merino To: Andreas Tobler Cc: bug-followup@freebsd.org Subject: Re: powerpc/182978: Kernel panic on boot on powerpc64 Date: Mon, 14 Oct 2013 23:26:41 -0400 Great, thanks a lot for the quick reply. That patch fixed the boot for me. On Mon, Oct 14, 2013 at 3:42 PM, Andreas Tobler wrote: > Hi, > > the reason is from this commit r256304. > > We're working on it. > > Basically, ata_probe does not longer return 0 and ata_kauai and > ata_macio fail now. This is due to the fact that these drivers do not > handle properly the BUS_* return codes other than 0. > > For the time being you can try the below. > > Gruss, > Andreas > > Index: powerpc/powermac/ata_kauai.c > =================================================================== > --- powerpc/powermac/ata_kauai.c (revision 256444) > +++ powerpc/powermac/ata_kauai.c (working copy) > @@ -199,7 +199,7 @@ > u_int32_t devid; > phandle_t node; > const char *compatstring = NULL; > - int i, found, rid; > + int err, i, found, rid; > > found = 0; > devid = pci_get_devid(dev); > @@ -252,8 +252,11 @@ > /* XXX: ATAPI DMA is unreliable. We should find out why. */ > ch->flags |= ATA_NO_ATAPI_DMA; > ata_generic_hw(dev); > + err = ata_probe(dev); > + if (err > 0) > + return (err); > > - return (ata_probe(dev)); > + return (0); > } > > #if USE_DBDMA_IRQ -- Julio Merino / @jmmv