From owner-freebsd-git@freebsd.org Wed Mar 1 12:08:00 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB296CF24AF for ; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A7B437AB for ; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mailman.ysv.freebsd.org (Postfix) id A6B4ACF24AE; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A630ACF24AD for ; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mail-ua0-f177.google.com (mail-ua0-f177.google.com [209.85.217.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6661F7AA for ; Wed, 1 Mar 2017 12:07:59 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mail-ua0-f177.google.com with SMTP id f54so39595620uaa.1 for ; Wed, 01 Mar 2017 04:07:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kKkaoK7czDzx9X6Cb2AxBhZL3+jLdtiybf3QIDiiYRw=; b=T0bUZBivyGjltsJjI9ZAXynq4anImZoOPDpnfNLDn68+gXCOJrLqhegcpanO+UYqMc jITcY9mo90yFtz0NSiCgIKkH9aGu2gx9utXpaYBZ11/OhT8yl0YraUzB5gvqxmeRDt6b ikGlha54lb5XYYHDBFb1dkqy6xD6JgaeNulNjPJkmQy4/IfIx3IwK9WH9NmI7XvMY7IR oco+b68b5zO3ISVkgAVvVmaq1Br5wZ/oKNMk1e8OIlUuw6tApOvmW1JbZzOKS9oyavom jfHQ1GeI4NyAQAjYgaNgEA2qj4ROWN5aqT9uRW2oaYN0aef3DAmNDI/KPErrHeQuGjyO Z4hw== X-Gm-Message-State: AMke39lryl2sGigNEe9z/0JuR+2IZMSPv+6GhGKsCDeUe5dNUMNkcnJiKJKinDgWy6p2gA== X-Received: by 10.176.82.86 with SMTP id j22mr3125447uaa.126.1488369670335; Wed, 01 Mar 2017 04:01:10 -0800 (PST) Received: from mail-ua0-f177.google.com (mail-ua0-f177.google.com. [209.85.217.177]) by smtp.gmail.com with ESMTPSA id n9sm37178vkc.25.2017.03.01.04.01.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 04:01:09 -0800 (PST) Received: by mail-ua0-f177.google.com with SMTP id x24so39509226uab.0 for ; Wed, 01 Mar 2017 04:01:09 -0800 (PST) X-Received: by 10.176.1.5 with SMTP id 5mr3080438uak.30.1488369669344; Wed, 01 Mar 2017 04:01:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.11.6 with HTTP; Wed, 1 Mar 2017 04:00:48 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= Date: Wed, 1 Mar 2017 12:00:48 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pull requests To: Kristof Provost Cc: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= , Warner Losh , git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:08:00 -0000 On Wed, Mar 1, 2017 at 11:52 AM, Kristof Provost wrote: > On 1 Mar 2017, at 10:36, Bart=C5=82omiej Rutkowski wrote: > >> What kind of policy, regarding what and 'policing' what and how exactly? >> Who and how will enforce such policy and on whom? In the end, "we can't >> force anyone to do anything" so unless we commit to do something on >> GitHub, >> I'd see it as a dead law. >> >> There is an official FreeBSD account on GitHub and I don=E2=80=99t expec= t that to > go > away. > > See > https://github.com/freebsd/freebsd/pulls > > (As an aside, I note that someone has been cleaning these up. Awesome.) > > We are getting pull requests there and something should be done with them= . > > Not to mention I've got a feeling this is completely disconnected from th= e >> general direction that I think has been 'agreed', that is we'll have a >> software solution getting GH PR's into Phabric reviews and GH Issues int= o >> Bugzilla PR's automatically. What then, shouldn't it be more like Phabri= c >> reviews/Bugzilla PR policy instead? >> >> This is probably a good answer to the question of what to do with those > pull > requests. > > As the current situation is =E2=80=9Cthey=E2=80=99re completely ignored= =E2=80=9D anything would be > an > improvement. Even automatically closing them with =E2=80=9CGo to in= stead.=E2=80=9D > would > be an improvement. > > It might be nice to document a review policy (usable for GitHub, > Phabricator, > e-mail reviews, =E2=80=A6) somewhere. Things like =E2=80=9CHow long do I = wait for > reviews?=E2=80=9D, > =E2=80=9CWho do I subscribe/cc/=E2=80=A6?=E2=80=9D, =E2=80=9CWhat should = be done with abandoned reviews?=E2=80=9D =E2=80=A6 > > I fully support Warner=E2=80=99s efforts. > > Regards, > Krsitof > Don't get me wrong, I am simply trying to understand what exactly would that accomplish - see https://reviews.freebsd.org/D9649. Lets, for a fun thought experiment, imagine it was an GH pull request that was transferred to Phabric. What now? 2 weeks passed and nothing happened. Would any policy fix that? Kind regards, Bartek Rutkowski