From owner-freebsd-arch@freebsd.org Thu Aug 8 20:17:29 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 31C42B1901 for ; Thu, 8 Aug 2019 20:17:29 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-9.consmr.mail.ne1.yahoo.com (sonic313-9.consmr.mail.ne1.yahoo.com [66.163.185.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 464KRW0FB7z4pRq for ; Thu, 8 Aug 2019 20:17:26 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: AVLOrmAVM1nAWUal3l.eFWA3qcw6p7GQq1x7bh9dHo1Rarm3crMoEXGt3XSG52b 61nWy8MU_sVC52YsPCv.VzEMXeFrUvvl1PdnR.xhRrdubRbb7cWmEk5_.liIDg60IR_F_xu0ysgl DnAYGw3ZR2ArofI7tQxfR7AQi1JLAHViasBTAcjGT46TimfcQUnV33WljteFWQDydqaMuuObclwB v357yx.8gYqHTdZENnF8BY.kW0kFIyD2mwGYIDAtl6H_kOTIg2jfyYZD7D2nQQomQSG9DKYIDl04 UnW1hdpx6A0osZNSTkvdCMMGQiegboJk09alI63Qe6.glQZqYLXNLvOGtkQIhkVF4J7H5NsudrLi R7RTIP6QrOGSWLUbKOC4QFb_Jti.zafPJ6vm3Puv5Yc56ElK0UmLlSqdywH6twrEdviKdTNdA4CJ .sXP3wb56gnpm6sz3.BZiHjQk83tDDCLGBk6n_Rm_EcRHrAxk8ratxxCj9bkB5eVe2INjAVx8GGU Y6fldci.Yi2zaogxEjbGTMSCJAtA_PLxgD7XsmjKM_LpUEy5zAw6rrlqymvp26u_OMKnW4WwS3OJ DR.kPO7a8gU0E.dGfMm8TrajErM5D8_vWeLPZ_zmJhgU_RD98Whxq4nfXATHHEDNpmh.sU6evt1V 3U0xbNe_jGRLC3m1b3t5qFWdqfAF9cyJuNldMAN.zlyaZZ__Ml98YTzLc_GTZ4NXyAHofX.3mCnf fHKcwqFM6UF4HJvuZjHaYFQqu8UdwT8Ne_ADNQc2nVKv.pXd4naW3P40PZTp5_Nu1ZXMCHsoCfgs hjaUe_xyoZBnRIslYnozD6v4T1ULPNuTHCtPbmbdiQN1KU__9154F2iEksm_sWx3ro3bp.fp7uqO Iv.XJ5hQAzRzu7V2o5xByJL8WLkkb4BjOQlATAVBXmyJ1ztQxegA.Dx4XYvjpYrWVgk6GP0xG3Ma HzPZqbDQACTWD19nUlj_vYVcgjo0GftMGl_Uu.MTXGI5WOPW0p_KXpQ7mTUg5nOqJWgD8xZp6AYU 5R2Wv8RKIfuCFkVrduqwE6_YuCpyNK4iWVGGzgqkpnRxM7O9ZX2cxtS6_fVYLoXwY6r2VkhRPvh3 ND7DSXZ30YqHNh0eFG1FWAutkeGjoLBc8ytO1G4rw.uYz6iKLEcwZ6vZtr1YhB1owuxEFVyRrE4V E3YVyOsU.HLuVvw4PGCAmvsdmA.ww4g_poOVwBr2IX1sJmjHjtyrFc4DrJnYUst7rfFqOw_FLsgR a1Vfi09E- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Thu, 8 Aug 2019 20:17:25 +0000 Received: by smtp417.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a23f480845d83a5bc481ce7f05f95e4e; Thu, 08 Aug 2019 20:17:21 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r350550 - head/share/mk Message-Id: <53987F8A-25FC-44D0-ACE0-680ECBFFEF48@yahoo.com> Date: Thu, 8 Aug 2019 13:17:19 -0700 To: freebsd-arch@freebsd.org X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 464KRW0FB7z4pRq X-Spamd-Bar: + X-Spamd-Result: default: False [1.47 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36646, ipnet:66.163.184.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; FAKE_REPLY(1.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; NEURAL_HAM_MEDIUM(-0.26)[-0.261,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.98)[0.978,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (1.57), ipnet: 66.163.184.0/21(1.27), asn: 36646(1.02), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_LONG(0.26)[0.258,0]; RCVD_IN_DNSWL_NONE(0.00)[32.185.163.66.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Aug 2019 20:17:29 -0000 Something has seemed incomplete in the descriptions that I've seen in the posts (based on a vague memory and observed behavior in my context). So I looked: # grep -r -U3 REPRO_FLAG /usr/src/sys/ /usr/src/stand/ | less /usr/src/sys/conf/kern.post.mk- ${NORMAL_CTFCONVERT} /usr/src/sys/conf/kern.post.mk- /usr/src/sys/conf/kern.post.mk-.if ${MK_REPRODUCIBLE_BUILD} !=3D "no" /usr/src/sys/conf/kern.post.mk:REPRO_FLAG=3D"-R" /usr/src/sys/conf/kern.post.mk-.endif /usr/src/sys/conf/kern.post.mk-vers.c: $S/conf/newvers.sh $S/sys/param.h = ${SYSTEM_DEP} /usr/src/sys/conf/kern.post.mk: MAKE=3D"${MAKE}" sh $S/conf/newvers.sh = ${REPRO_FLAG} ${KERN_IDENT} /usr/src/sys/conf/kern.post.mk- /usr/src/sys/conf/kern.post.mk-vnode_if.c: $S/tools/vnode_if.awk = $S/kern/vnode_if.src /usr/src/sys/conf/kern.post.mk- ${AWK} -f $S/tools/vnode_if.awk = $S/kern/vnode_if.src -c -- /usr/src/stand/loader.mk-CLEANFILES+=3D vers.c /usr/src/stand/loader.mk-VERSION_FILE?=3D ${.CURDIR}/version /usr/src/stand/loader.mk-.if ${MK_REPRODUCIBLE_BUILD} !=3D no /usr/src/stand/loader.mk:REPRO_FLAG=3D -r /usr/src/stand/loader.mk-.endif /usr/src/stand/loader.mk-vers.c: ${LDRSRC}/newvers.sh ${VERSION_FILE} /usr/src/stand/loader.mk: sh ${LDRSRC}/newvers.sh ${REPRO_FLAG} = ${VERSION_FILE} \ /usr/src/stand/loader.mk- ${NEWVERSWHAT} /usr/src/stand/loader.mk- /usr/src/stand/loader.mk-.if ${MK_LOADER_VERBOSE} !=3D "no" Then the question is the -r vs. -R distinction (for just /usr/src/sys/conf/newvers.sh as it turns out, /usr/src/stand/loader.mk only supports -r use): . . . # -r Reproducible build. Do not embed directory names, user = names, # time stamps or other dynamic information into the output = file. # This is intended to allow two builds done at different = times # and even by different people on different hosts to = produce # identical output. # # -R Reproducible build if the tree represents an unmodified # checkout from a version control system. Metadata is = included # if the tree is modified. . . . include_metadata=3Dyes modified=3Dno while getopts crRvV: opt; do case "$opt" in c) echo "$COPYRIGHT" exit 0 ;; r) include_metadata=3Dno ;; R) include_metadata=3Dif-modified ;; . . . As stands -r is never used for sys/conf/newvers.sh unless one changes /usr/src/sys/conf/kern.post.mk or some such. So if I use WITH_REPRODUCEABLE_BUILD I still see the varying metadata (but I do not have an independent svn with my own checkins, just differences with FreeBSD svnlite update -r?????? materials). May be what some folks are asking for is some means of control over -R vs. -r being supplied to sys/conf/newvers.sh , without having to edit sys/conf/kern.post.mk ? =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)