From nobody Fri Jun 27 20:18:58 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bTRhz27hMz60C99; Fri, 27 Jun 2025 20:18:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bTRhz0qDjz3KK6; Fri, 27 Jun 2025 20:18:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751055539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FUo1j99dVRCS2XwJFnmg+OdyDpPHgl1hiOyLAA+DosA=; b=HbkwUUxW7aSn8NA9uqKN/XOOdYWDd3KWNzc6zzm/DvBiELPI0SS3MKdMF/F20WhD6DUxWI F7cvkd91cnTS7EX8PMnbcN2/bbv/RpFUKXLU61Dqc4S07CIwsEsxSiaqAJCn3QPuKF/xQV C68S8Pgzr+HtY3s0Abyw4yi0e9yGJmoCusqxjn7k0X3JSFUw6DXqlHEcxNhu7WRNRE0FO6 Fko3c3yUiAA8sP7sYin8HN+qehIYueVPVTeyK7wq8A4MKEEjkR8Jp+Xb/7yzB3dWAS458A 25KGxOK2kpJwKgkKcmw3SEaSpKKWHnP+ATfCOPAB5540yys4AscJETu7GXd6bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751055539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FUo1j99dVRCS2XwJFnmg+OdyDpPHgl1hiOyLAA+DosA=; b=tn8idocumfCqNMOfXok0FF3+G0OwseO39jkKpnAAe8m4BPWS2vi1XSaNrXH3d62Lp3/9Hx IBBbUeyDD4lVFeCAIuQ3sapg/wCJt19fwxoluT7Qgf4WnXEKQC3IIfwrApVFbxRv9H37Wb Q6VXXv+Pi2CBk0Mip1e/R6AQ7WGFiyLyyWwuhQRjyy3ikKeljBLxM4sg4muu9OZAWrGhXq 04ALk9fr7TP9CtDfWUU/81oRJK0DejyThx2BxwDrOJUqCpw4eCH738KWhY2GiT3RWcNRXV zmCMsG+5qdHdIcbjCjyQQPCqyK4NoMo1odX156sykRdlbYlC0Ivz5y/P5UPE8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751055539; a=rsa-sha256; cv=none; b=WNNWBuDllmSa0GDuvEjWT5BTBHCRX1weIkydQzGndfCQwWaqC5xwlnfrmEZUO3cs9WAnEJ c6ozeB6TZTYXpAB9Ets2Oh7edWRGFZ/DmHioQaMThWa8d86b0Fh2W2oGU6zfMfXKJ4ifV9 ktsEOsQLIdq65V5SpdgDbOyHLmZFDTw/bCXuPXGDBhrsgoLMj0dLK+I138dnVrUZckgP2x +QLdcYXIbrtgxYRPYriNQzR8OnZwDMok/hkoHoqjtQmxVdLx+BPuoPrEzZ4z23DF89G3a/ xDnuIPGbuOuVTC2hUkXocVxMr68BOgfRSSpagQnBGJ9AmmzcvWx78f1zNL6Wsw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bTRhz00Tkz12DR; Fri, 27 Jun 2025 20:18:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55RKIwnD013514; Fri, 27 Jun 2025 20:18:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55RKIw5D013511; Fri, 27 Jun 2025 20:18:58 GMT (envelope-from git) Date: Fri, 27 Jun 2025 20:18:58 GMT Message-Id: <202506272018.55RKIw5D013511@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 9c014cc25c43 - main - Revert "rc: Disable pathname expansion when calling run_rc_command()" List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9c014cc25c437d2c4e18a7554e1276e0f290a8a0 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=9c014cc25c437d2c4e18a7554e1276e0f290a8a0 commit 9c014cc25c437d2c4e18a7554e1276e0f290a8a0 Author: Mark Johnston AuthorDate: 2025-06-27 18:59:54 +0000 Commit: Mark Johnston CommitDate: 2025-06-27 20:18:36 +0000 Revert "rc: Disable pathname expansion when calling run_rc_command()" At least nuageinit is broken after this commit, breaking some downstream CI systems. It also disables globbing for rc.local scripts, which is likely to break users in surprising ways. This reverts commit 4deb9760a9d84d5861ee45162ffebe83f13503b8. --- libexec/rc/rc.subr | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libexec/rc/rc.subr b/libexec/rc/rc.subr index 359eebd1d342..2eaf336b5220 100644 --- a/libexec/rc/rc.subr +++ b/libexec/rc/rc.subr @@ -1788,11 +1788,7 @@ _run_rc_doit() debug "run_rc_command: doit: $*" _m=$(umask) ${_umask:+umask ${_umask}} - - # Disable pathname expansion temporarily for run_rc_command. - set -o noglob eval "$@" - set +o noglob _return=$? umask ${_m}