From owner-svn-src-all@freebsd.org Wed Sep 11 21:50:14 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C9091E0E46 for ; Wed, 11 Sep 2019 21:50:14 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46TFtt2qpXz4SFW for ; Wed, 11 Sep 2019 21:50:14 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1568238612; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=lnhemp8RmnbVowuzl6zsBj3dUt6KHe6AbKeDyFuKQ8gn0OcPf/valE5iQSIh/P/bcZcE44/ZWtM5z qGtrk9H+BFm9ethWWU36bAnwPOT/wqyisHAXgSGC0xy2pvOiOxlWNT1218GwpU4h+wvzQz9O6aR+yQ tT4gBJeF3EI42HmIpAr/g8AMe3C+pDwtqTv0dFE3V6S0myK1vxq/FJBN8AOHl8u9d9h/lETWB8rc0m S4lc+Hoj+Bi/iycTrx5vRRZ1bgeEiatDixvaM9WbeZDgz00jxLE7dsiETr+KD5VoXiVd3HYyYupr37 UkAYQtaLDyVPEYW74TBIJng9euJRoog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=l/dTDqAsV1kHlqTpnMmxfL3cNNYg/MSs2AtV1h0Fs6I=; b=ikuut5c73l7U4qe7yfXYTDoRoft89sGwATd9tVlGupYSWzzgDnMFm//ARftPofdKoDPuJfTDa5Kqd YKqThpLMQVxOgV8bgC0uq9N1nstMSE8fanIOr9bqQzmRFYiZ3SjXyLLG5tmm0Hq6V8s67ZwpQod6Yg AwD2lMPC4u+SywYnXNlE57/rwaaG0oz2RMb6IzJEFcIIC9oGHvO1YUao8mfV82oz4kpBUDz/bvyHOR XwnPVhV4eWpPSAekZDJW6hCO1gdCjdIdmO6UWALqTcFGYCDMre3ftivI7rTZ3/fqEnQ23VKNYNUG0K AFmanT4PJiZLPJSDEgnSpRVre37PggA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=l/dTDqAsV1kHlqTpnMmxfL3cNNYg/MSs2AtV1h0Fs6I=; b=nhlapw1nLz47LREXB9h0J7rqg9IQwLZEui7CnRzR9Ve36n1AMVZZzZMHiGvxG2XlcJ4i/2ytToMYu 5RcSYyQIFgVDPExkQ/Cg9ztymAYSpvUGox3JwJzdyCEWkr2LfCSF65f87h6uNMYKHGO5UbXnLZGSAS nzLIUvwBkzI4uAJAfdZg3LdLgtn9py3GOaSnZGDB1eHmaUIBBr0uzPdI4E8o0EM/0Alq4k4zQ7V+ly sJU69dkEYfuGtxdv03syQnxsT6x+JpKeOQ1VBCzLPK/Wd/MpiK+bbXbuHNy+HqTCOGTo/uuQF2qyYA g+YByCqXAurB6Wr2jXVxHjTsKOGXYTw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 1ff9ce29-d4de-11e9-b67d-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 1ff9ce29-d4de-11e9-b67d-cdd75d6ce7a8; Wed, 11 Sep 2019 21:50:11 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x8BLo9dx074593; Wed, 11 Sep 2019 15:50:09 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <63cf915c92b92b07e19337849269ec6bd0dc0d1b.camel@freebsd.org> Subject: Re: svn commit: r352231 - head/lib/libc/sys From: Ian Lepore To: Alan Somers , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 11 Sep 2019 15:50:09 -0600 In-Reply-To: <201909111948.x8BJmWZn092483@repo.freebsd.org> References: <201909111948.x8BJmWZn092483@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46TFtt2qpXz4SFW X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.00 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Sep 2019 21:50:14 -0000 On Wed, 2019-09-11 at 19:48 +0000, Alan Somers wrote: > Author: asomers > Date: Wed Sep 11 19:48:32 2019 > New Revision: 352231 > URL: https://svnweb.freebsd.org/changeset/base/352231 > > Log: > getsockopt.2: clarify that SO_TIMESTAMP is not 100% reliable > > When SO_TIMESTAMP is set, the kernel will attempt to attach a timestamp as > ancillary data to each IP datagram that is received on the socket. However, > it may fail, for example due to insufficient memory. In that case the > packet will still be received but not timestamp will be attached. > > Reviewed by: kib > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D21607 > > Modified: > head/lib/libc/sys/getsockopt.2 > > Modified: head/lib/libc/sys/getsockopt.2 > ============================================================================== > --- head/lib/libc/sys/getsockopt.2 Wed Sep 11 19:29:40 2019 (r352230) > +++ head/lib/libc/sys/getsockopt.2 Wed Sep 11 19:48:32 2019 (r352231) > @@ -28,7 +28,7 @@ > .\" @(#)getsockopt.2 8.4 (Berkeley) 5/2/95 > .\" $FreeBSD$ > .\" > -.Dd February 10, 2019 > +.Dd September 11, 2019 > .Dt GETSOCKOPT 2 > .Os > .Sh NAME > @@ -431,7 +431,8 @@ option is enabled on a > .Dv SOCK_DGRAM > socket, the > .Xr recvmsg 2 > -call will return a timestamp corresponding to when the datagram was received. > +call may return a timestamp corresponding to when the datagram was received. > +However, it may not, for example due to a resource shortage. > The > .Va msg_control > field in the > So I guess this actually happened to someone... is it a common thing for the timestamp to fail? I ask because ntpd relies on SO_TIMESTAMP and if this situation really happens and can persist for a long time, ntpd would effectively stop working. -- Ian