From owner-cvs-all  Thu Jan 16 10:35:22 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A7F9937B401; Thu, 16 Jan 2003 10:35:21 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2710543F3F; Thu, 16 Jan 2003 10:35:20 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id FAA11709;
	Fri, 17 Jan 2003 05:35:15 +1100
Date: Fri, 17 Jan 2003 05:36:24 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Nate Lawson <nate@root.org>
Cc: Hidetoshi Shimokawa <simokawa@FreeBSD.org>,
	<cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c  
       fwohcivar.h
In-Reply-To: <Pine.BSF.4.21.0301161007080.46845-100000@root.org>
Message-ID: <20030117052637.I3675-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Thu, 16 Jan 2003, Nate Lawson wrote:

> On Thu, 16 Jan 2003, Hidetoshi Shimokawa wrote:
> >   Modified files:
> >     sys/dev/firewire     firewire.c fwdev.c fwohci.c fwohcivar.h
> >...
>
> Some comments.
>
> > -		contigfree((void *)(uintptr_t)sc->fc.sid_buf,
> > -					OHCI_SIDSIZE, M_DEVBUF);
> > +		free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF);
>
> Unnecessary casts (there are others).

Er, these casts seem to be necessary to break warnings from -Wcast-qual.
sid_buf has type "volatile u_int32_t *".

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message