From owner-svn-src-all@FreeBSD.ORG Sat Oct 8 20:07:37 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9F2F8106564A; Sat, 8 Oct 2011 20:07:37 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 4E4A58FC0C; Sat, 8 Oct 2011 20:07:37 +0000 (UTC) Received: by iaby12 with SMTP id y12so592645iab.13 for ; Sat, 08 Oct 2011 13:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=MyiGyUoDteLk30dlMxL68SeZmwuNZBPWH2S3C1SEp/E=; b=oLT1+Vjy69DUxzJAt4pBK0TDANz193+kUcyrJTjKQCz4kseR358paGZAJJwA6Zr8rb kBzgy3KGhm74cI9HA6z7KoMJONcSe8sVWxW+YMPyYJauc/xH5+GqJAJodZBxNGk/6IkI JEeY/XTniBuwxDdRFGjksNqw1OnBvmoKU/rdQ= MIME-Version: 1.0 Received: by 10.231.69.80 with SMTP id y16mr5729319ibi.34.1318103124206; Sat, 08 Oct 2011 12:45:24 -0700 (PDT) Sender: utisoft@gmail.com Received: by 10.231.35.194 with HTTP; Sat, 8 Oct 2011 12:45:24 -0700 (PDT) Received: by 10.231.35.194 with HTTP; Sat, 8 Oct 2011 12:45:24 -0700 (PDT) In-Reply-To: <4E90A5D4.9020006@FreeBSD.org> References: <201110081825.p98IP22D073560@svn.freebsd.org> <4E90A5D4.9020006@FreeBSD.org> Date: Sat, 8 Oct 2011 20:45:24 +0100 X-Google-Sender-Auth: PUZRSJi2YNAOQ5GJd5rqssYazoc Message-ID: From: Chris Rees To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226162 - head/share/mk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Oct 2011 20:07:37 -0000 On 8 Oct 2011 20:35, "Doug Barton" wrote: > > On 10/08/2011 11:25, Chris Rees wrote: > > Author: crees (ports committer) > > Date: Sat Oct 8 18:25:01 2011 > > New Revision: 226162 > > URL: http://svn.freebsd.org/changeset/base/226162 > > > > Log: > > Revert unapproved commit to bsd.port.mk. > > This is completely unacceptable. We don't do "commit wars" in FreeBSD. > IF it's accurate that portmgr has custody on this file (as opposed to > ports/Mk/bsd.port.mk where they unquestionably do), and IF portmgr had a > problem with this commit, it's up to them to deal with it. The fact that > you don't think it's a good idea (for whatever reason) frankly isn't > relevant. > > > This would have had more discussion, but it was explicitly rejected at submission by portmgr: > > > > http://lists.freebsd.org/pipermail/freebsd-ports/2011-September/070591.html > > I read that message as rejecting the idea of applying it to > ports/Mk/bsd.port.mk, and I think Jilles and Ed applied a very creative > solution to keeping things moving on HEAD without impacting the ports > tree itself. > This was subverting maintainer approval, whether inadvertent or not. It has nothing to do with whether I think it's a good idea or not, but please remember that this took place behind the back of the majority of the developers it affected, including me. Wherever the file is, and however creative the solution is, and however you read Erwin's message, the answer is clear; portmgr disapproves, please don't do it, because ports@ is where the fallout will happen. When I installed CURRENT I was surprised to find the problems impossible to reproduce, and that was because this fragment was put in an obscure place. We may not do revert wars, but I have to go through the proper process of getting stuff into bsd.port.mk, and so does everyone else. Please don't let's hold multiple conversations, feel free to bring my other email before developers@. Chris