Date: Tue, 15 May 2012 08:19:05 -0500 From: "Bryan Drewery" <bryan@shatow.net> To: FreeBSD-gnats-submit@FreeBSD.org Cc: eadler@FreeBSD.org, beat@FreeBSD.org Subject: ports/167923: [PATCH] ports-mgmt/portlint: Make NO_CHECKSUM error more strict. Message-ID: <20120515131932.180811065674@hub.freebsd.org> Resent-Message-ID: <201205151320.q4FDK2LY049630@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 167923
>Category: ports
>Synopsis: [PATCH] ports-mgmt/portlint: Make NO_CHECKSUM error more strict.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Tue May 15 13:20:01 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Bryan Drewery
>Release: FreeBSD 8.3-RELEASE i386
>Organization:
>Environment:
>Description:
Update error for NO_CHECKSUM to be more strict. Use the wording from bsd.port.mk instead of 'discouraged' which implies it is ok in some cases.
>How-To-Repeat:
>Fix:
--- patch-portlint-NO_CHECKSUM.txt begins here ---
diff --git Makefile Makefile
index 320a3e8..649e30b 100644
--- Makefile
+++ Makefile
@@ -8,7 +8,7 @@
#
PORTNAME= portlint
-PORTVERSION= 2.13.9
+PORTVERSION= 2.13.10
CATEGORIES= ports-mgmt
MASTER_SITES= # none
DISTFILES= # none
diff --git src/portlint.pl src/portlint.pl
index 1eee0c3..12ff3ce 100644
--- src/portlint.pl
+++ src/portlint.pl
@@ -1606,8 +1606,8 @@ sub checkmakefile {
print "OK: checking NO_CHECKSUM.\n" if ($verbose);
if ($whole =~ /\nNO_CHECKSUM/) {
my $lineno = &linenumber($`);
- &perror("FATAL", $file, $lineno, "use of NO_CHECKSUM discouraged. ".
- "it is intended to be a user variable.");
+ &perror("FATAL", $file, $lineno, "NO_CHECKSUM is a user ".
+ "variable and is not to be set in the a port's Makefile.");
}
#
--- patch-portlint-NO_CHECKSUM.txt ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120515131932.180811065674>