From owner-svn-src-all@freebsd.org Sat Jul 25 00:58:51 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83FEE9AAB2C; Sat, 25 Jul 2015 00:58:51 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A0641FA0; Sat, 25 Jul 2015 00:58:51 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t6P0wpuX026327; Sat, 25 Jul 2015 00:58:51 GMT (envelope-from gonzo@FreeBSD.org) Received: (from gonzo@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t6P0wpe1026326; Sat, 25 Jul 2015 00:58:51 GMT (envelope-from gonzo@FreeBSD.org) Message-Id: <201507250058.t6P0wpe1026326@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: gonzo set sender to gonzo@FreeBSD.org using -f From: Oleksandr Tymoshenko Date: Sat, 25 Jul 2015 00:58:51 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r285865 - head/sys/dev/ofw X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jul 2015 00:58:51 -0000 Author: gonzo Date: Sat Jul 25 00:58:50 2015 New Revision: 285865 URL: https://svnweb.freebsd.org/changeset/base/285865 Log: OF_getencprop_alloc shouldn't be used to get string value. If string length + 1 is not divisible by 4 this function returns NULL property value. Otherwise - string with each 4 letters inverted Modified: head/sys/dev/ofw/ofw_bus_subr.c Modified: head/sys/dev/ofw/ofw_bus_subr.c ============================================================================== --- head/sys/dev/ofw/ofw_bus_subr.c Sat Jul 25 00:21:29 2015 (r285864) +++ head/sys/dev/ofw/ofw_bus_subr.c Sat Jul 25 00:58:50 2015 (r285865) @@ -395,7 +395,7 @@ ofw_bus_reg_to_rl(device_t dev, phandle_ * This may be just redundant when having ofw_bus_devinfo * but makes this routine independent of it. */ - ret = OF_getencprop_alloc(node, "name", sizeof(*name), (void **)&name); + ret = OF_getprop_alloc(node, "name", sizeof(*name), (void **)&name); if (ret == -1) name = NULL; @@ -511,7 +511,7 @@ ofw_bus_find_child(phandle_t start, cons phandle_t child; for (child = OF_child(start); child != 0; child = OF_peer(child)) { - ret = OF_getencprop_alloc(child, "name", sizeof(*name), (void **)&name); + ret = OF_getprop_alloc(child, "name", sizeof(*name), (void **)&name); if (ret == -1) continue; if (strcmp(name, child_name) == 0) {