Date: Fri, 07 Nov 2014 16:19:52 +0100 From: John Marino <freebsd.contact@marino.st> To: Ryan Steinmetz <zi@FreeBSD.org>, marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r372261 - in head/devel/ding-libs: . files Message-ID: <545CE318.6000000@marino.st> In-Reply-To: <20141107151238.GA76739@exodus.zi0r.com> References: <201411071333.sA7DXdtR038743@svn.freebsd.org> <545CCF05.70609@marino.st> <20141107151238.GA76739@exodus.zi0r.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/7/2014 16:12, Ryan Steinmetz wrote:
> On (11/07/14 14:54), John Marino wrote:
>> On 11/7/2014 14:33, Ryan Steinmetz wrote:
>>> +LIBS+= -L${LOCALBASE}/lib -liconv -lintl
>>
>> shouldn't that be:
>> LIBS+= -L${LOCALBASE}/lib ${ICONVLIB} -lintl
>>
>> or something like that?
>
> Not unless you can tell me what defines ICONVLIB. :)
>
Mk/Uses/iconv.mk
setting it unconditionally is normally wrong. iconv.mk defines it when
it's needed.
John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?545CE318.6000000>