Date: Wed, 15 Mar 2017 08:26:12 -0500 From: Kyle Evans <bsdports@kyle-evans.net> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r436241 - in head/comms: . multimon-ng multimon-ng/files Message-ID: <CACNAnaFf-BRRArxhWyst4nk56HyCYgs%2B0fj_vPOGkaVnLGjEjw@mail.gmail.com> In-Reply-To: <20170315131844.GB39784@FreeBSD.org> References: <201703151313.v2FDDA2i048896@repo.freebsd.org> <20170315131844.GB39784@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 15, 2017 at 8:18 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Wed, Mar 15, 2017 at 01:13:10PM +0000, Diane Bruce wrote: >> New Revision: 436241 >> URL: https://svnweb.freebsd.org/changeset/ports/436241 >> >> Log: >> multimon-ng a fork of multimon. >> It decodes the following digital transmission modes: >> ... >> +PLIST_FILES+= bin/multimon-ng > > Why += here? > >> +.include <bsd.port.pre.mk> >> +.if ${PORT_OPTIONS:MX11} >> +USE_XORG+= sm ice x11 xext >> +.endif > > Why not use option helpers (esp. since you're already using them above)? I'm afraid the reasoning for this one is kind of a sad one. I keep overlooking _USE= when reviewing bsd.options.mk for my options because of the similarities to _USES=, which actually doesn't seem to be formally documented at the top like I thought. For some reason it just doesn't seem as neat to me as the non-options-helper equivalents. I can submit a patch in a bit to convert that to: X11_USE= XORG=sm,ice,x11,xext Apologies, Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFf-BRRArxhWyst4nk56HyCYgs%2B0fj_vPOGkaVnLGjEjw>