Date: Fri, 18 Sep 2020 14:28:15 +0200 (CEST) From: Ronald Klop <ronald-lists@klop.ws> To: John Baldwin <jhb@FreeBSD.org> Cc: "Andrey V. Elsukov" <ae@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>, =?UTF-8?Q?Olivier_Cochard-Labb=C3=A9?= <olivier@freebsd.org> Subject: Re: svn commit: r365449 - head/sbin/rcorder Message-ID: <1309102481.46.1600432095907@localhost> In-Reply-To: <86cadaa8-12e6-8b61-a8d1-758a7722b795@FreeBSD.org> References: <202009081036.088AaCk8085096@repo.freebsd.org> <CA%2Bq%2BTcr%2B3Gp4EcmJoLYC0JEOmuVzYdujMQdC4P=n9Zi4jYMmkQ@mail.gmail.com> <1ccf2cf7-eb01-a200-4335-4674a010f8a1@FreeBSD.org> <CA%2Bq%2BTcq0um=SjmFdP-thcKhf7DGuBxewc0E-690HB0tT5riVaw@mail.gmail.com> <86cadaa8-12e6-8b61-a8d1-758a7722b795@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
=20 Van: John Baldwin <jhb@FreeBSD.org> Datum: vrijdag, 18 september 2020 00:50 Aan: "Olivier Cochard-Labb=C3=A9" <olivier@freebsd.org> CC: "Andrey V. Elsukov" <ae@freebsd.org>, src-committers <src-committers@fr= eebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-he= ad@freebsd.org> Onderwerp: Re: svn commit: r365449 - head/sbin/rcorder >=20 > On 9/17/20 3:44 PM, Olivier Cochard-Labb=C3=A9 wrote: > > On Thu, Sep 17, 2020 at 10:21 PM John Baldwin <jhb@freebsd.org> wrote: > >> I think long term we want OCF's notions of sessions to be a bit more > >> fluid such that "client" sessions for things like GELI and IPSec can > >> be backed by one or more "driver" sessions (including "driver" session= s > >> coming and going as devices come and go). That's a fair bit more work > >> however. > >> > >> > > And why not simply add 'kld' into the REQUIRE part of /etc/rc.d/ipsec ? > > But this will fix only IPsec: What about other crypto consumers ? >=20 > The problem is that kld_list can be used to load all sorts of modules. > Perhaps some of them need to be loaded after the network is configured, > for example, but ipsec is probably before NETWORKING, so moving kld > earlier would break those modules. The problem with 'kld' is that it is > super generic so there isn't a "right" place to put it. >=20 > I'm not sure of an easy solution. In your case, if you put aesni_load=3D= YES > in loader.conf instead of putting aesni in kld_list you would be fine > though. I'm not sure it's really safe to assume that things loaded by > kld_list are available for any boot-time services. >=20 > --=20 > John Baldwin > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >=20 >=20 >=20 Another solution could be to create a /etc/rc.d/aesni script which loads th= e aesni module and use that for dependencies instead of the generic kld_lis= t. Or a more generic /etc/rc.d/cryptostuff. Regards, Ronald. =20 From owner-svn-src-all@freebsd.org Fri Sep 18 12:30:16 2020 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F6713E2670; Fri, 18 Sep 2020 12:30:16 +0000 (UTC) (envelope-from markj@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BtCpc2pCHz4VqB; Fri, 18 Sep 2020 12:30:16 +0000 (UTC) (envelope-from markj@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3E62A1B055; Fri, 18 Sep 2020 12:30:16 +0000 (UTC) (envelope-from markj@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 08ICUFdW069047; Fri, 18 Sep 2020 12:30:15 GMT (envelope-from markj@FreeBSD.org) Received: (from markj@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 08ICUF7u069046; Fri, 18 Sep 2020 12:30:15 GMT (envelope-from markj@FreeBSD.org) Message-Id: <202009181230.08ICUF7u069046@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: markj set sender to markj@FreeBSD.org using -f From: Mark Johnston <markj@FreeBSD.org> Date: Fri, 18 Sep 2020 12:30:15 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r365877 - head/lib/libc/sys X-SVN-Group: head X-SVN-Commit-Author: markj X-SVN-Commit-Paths: head/lib/libc/sys X-SVN-Commit-Revision: 365877 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 18 Sep 2020 12:30:16 -0000 Author: markj Date: Fri Sep 18 12:30:15 2020 New Revision: 365877 URL: https://svnweb.freebsd.org/changeset/base/365877 Log: Fix error checking in shm_create_largepage(). Reviewed by: alc, kib Reported by: Coverity MFC with: r365524 Differential Revision: https://reviews.freebsd.org/D26464 Modified: head/lib/libc/sys/shm_open.c Modified: head/lib/libc/sys/shm_open.c ============================================================================== --- head/lib/libc/sys/shm_open.c Fri Sep 18 11:22:34 2020 (r365876) +++ head/lib/libc/sys/shm_open.c Fri Sep 18 12:30:15 2020 (r365877) @@ -65,7 +65,7 @@ shm_create_largepage(const char *path, int flags, int int error, fd, saved_errno; fd = __sys_shm_open2(path, flags | O_CREAT, mode, SHM_LARGEPAGE, NULL); - if (error == -1) + if (fd == -1) return (-1); memset(&slc, 0, sizeof(slc));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1309102481.46.1600432095907>