From owner-svn-ports-all@FreeBSD.ORG Tue Mar 24 18:31:36 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CF2EFCCE; Tue, 24 Mar 2015 18:31:36 +0000 (UTC) Received: from mx1a.lautre.net (eyra.lautre.net [80.67.160.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.lautre.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 577DC260; Tue, 24 Mar 2015 18:31:35 +0000 (UTC) Received: from graf.pompo.net (graf.pompo.net [78.225.128.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: thierry@pompo.net) by mx1a.lautre.net (Postfix) with ESMTPSA id B8AC34116E; Tue, 24 Mar 2015 19:31:32 +0100 (CET) Received: by graf.pompo.net (Postfix, from userid 1001) id 1CCAF71E447; Tue, 24 Mar 2015 19:31:32 +0100 (CET) Date: Tue, 24 Mar 2015 19:31:32 +0100 From: Thierry Thomas To: John Marino Subject: Re: svn commit: r382100 - in head: archivers/pixz archivers/pixz/files dns/dualserver french/aster japanese/scim-skk news/nzbget ports-mgmt/bpm sysutils/freeipmi x11-wm/libcompizconfig Message-ID: <20150324183132.GD11473@graf.pompo.net> Mail-Followup-To: John Marino , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201503241351.t2ODpIjS082125@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb" Content-Disposition: inline In-Reply-To: <201503241351.t2ODpIjS082125@svn.freebsd.org> X-Operating-System: FreeBSD 10.1-STABLE amd64 Organization: Kabbale Eros X-Face: (hRbQnK~Pt7$ct`!fupO(`y_WL4^-Iwn4@ly-.,[4xC4xc; y=\ipKMNm<1J>lv@PP~7Z<.t KjAnXLs: X-PGP: 0xF1C516B3C8359753 User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2015 18:31:37 -0000 --VS++wcV0S1rZb1Fb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On tue 24 mar 15 at 14:51:18 +0100, John Marino wrote: > Author: marino > Date: Tue Mar 24 13:51:17 2015 > New Revision: 382100 > URL: https://svnweb.freebsd.org/changeset/ports/382100 > QAT: https://qat.redports.org/buildarchive/r382100/ >=20 > Log: > 8 ports categories: Remove $PTHREAD_LIBS > =20 > Categories: archivers, dns, french, japanese, news, port-mgmt, x11-wm > =20 > The sysutils port was setting configure argument, so the text wasn't > removed but the value of PTHREAD_LIBS was changed. > =20 > approved by: PTHREAD blanket >=20 > Modified: > head/archivers/pixz/Makefile > head/archivers/pixz/files/Makefile.in > head/dns/dualserver/Makefile > head/french/aster/Makefile > head/japanese/scim-skk/Makefile > head/news/nzbget/Makefile > head/ports-mgmt/bpm/Makefile > head/sysutils/freeipmi/Makefile > head/x11-wm/libcompizconfig/Makefile 8< 8< 8< > Modified: head/french/aster/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/french/aster/Makefile Tue Mar 24 13:43:16 2015 (r382099) > +++ head/french/aster/Makefile Tue Mar 24 13:51:17 2015 (r382100) > @@ -252,9 +252,9 @@ pre-configure: > ${ECHO_CMD} "F90=3D'${FC}'" >> ${WRKSRC}/setup.cfg > ${ECHO_CMD} "MATHLIB=3D'${lib_math} ${LDFLAGS} -lgfortran -lm -lkvm'" \ > >> ${WRKSRC}/setup.cfg > - ${ECHO_CMD} "OTHERLIB=3D'-Xlinker -export-dynamic -lutil ${PTHREAD_LIBS= } -lz'" \ > + ${ECHO_CMD} "OTHERLIB=3D'-Xlinker -export-dynamic -lutil -lpthread -lz'= " \ I agree with you when you remove lines or patches such as s/-lpthread/${PTHREAD_LIBS}/ but I disagree with your changes here: it's better to add ${PTHREAD_LIBS} than -lpthread. --=20 Th. Thomas. --VS++wcV0S1rZb1Fb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQJ8BAEBCgBmBQJVEa2DXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFNTM2QkU4NTM4NTM5OUQwMEI2RkFBNzZG MUM1MTZCM0M4MzU5NzUzAAoJEPHFFrPINZdT8SQP/3IRU+NAFHN9K6lCMkOVrHED LTJ1PATCWCw3ZEjIDJqIGMzm9WH94P8SOIT81yJpA2DpLVRlQK4buUqn84FuID4W jXkchORBKPFYuzfM1SQcCVPzMgf7VB7M3jiajR8sDnf+gXrd1htulWjYEwQE70VO Ax1sGR22Ck2t1+hNAzdWhPZetv6DH8rzY/SyoWgkbe3wbTbqc1PgTmOcJERJQXHP Cbz915+VZJ0UplohDIlQ1pTnNg6I864noDWEux356I3rpCkhGdQU7db+otaEBbt4 u/a2zzPJH20KFu3IGn79bhi8Ektg8Ni/kysJ/gQwiYmi6McCbjbeoBHiTNL2DrLJ Kdac7s7ZvERN8wlwmcJGJWVxzfEDMIV4e+84mCCbmF61unOVigAU+nCerZf99J1S Ha1acgMF+51XSY5aYsk+sD1JejxQnDJvF1+/Qse0OR9jOXJtgXWIsvD4Pp1whnCD LFS1lWJj2DK+unN5l2Xll1XYtuGSqXQ0tJbTVX7aJ9B+usJfKKpFklurmKVYGwQm FlhQNSMCmMu/iFDF6Pc8qCK1O0QilQtejL62mRQEaTKGtkRru/ZfShhkcdqaWfyA zoeE7aJjv6t+HtKIHwJB7unKFT6dz7riJH2s0EpWjENDVf5F2ccJUSmYTLL0o5Jg IN70tf34mFyzNZgoqxpj =ESXC -----END PGP SIGNATURE----- --VS++wcV0S1rZb1Fb--