From owner-freebsd-current@FreeBSD.ORG Thu Nov 11 19:09:11 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 779FA16A4CE for ; Thu, 11 Nov 2004 19:09:11 +0000 (GMT) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.198]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DE8043D31 for ; Thu, 11 Nov 2004 19:09:11 +0000 (GMT) (envelope-from astrodog@gmail.com) Received: by rproxy.gmail.com with SMTP id a36so347870rnf for ; Thu, 11 Nov 2004 11:09:10 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=nV472TI3TXoyw35q5VHxd72m+7FFxJIij8Q7PAnWUluMZx0DYrdndttWdJnnHQBwnFcSD1qbkvYJUPpuFzLhkyEy/XV1o50028xtO6KkfZ5kZXt1jnQ0DzPf0BmBSbgH5XnMJ4RlCN7DisnX/4aGyaaQtdhvRueR7TUaPUsUpI4= Received: by 10.38.99.62 with SMTP id w62mr501961rnb; Thu, 11 Nov 2004 11:09:10 -0800 (PST) Received: by 10.38.164.65 with HTTP; Thu, 11 Nov 2004 11:09:10 -0800 (PST) Message-ID: <2fd864e04111111094c7da80b@mail.gmail.com> Date: Thu, 11 Nov 2004 13:09:10 -0600 From: Astrodog To: John-Mark Gurney , freebsd-current@freebsd.org, freebsd-amd64@freebsd.org In-Reply-To: <20041111184040.GF54817@funkthat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <2fd864e04111105557032a7c3@mail.gmail.com> <20041111153114.GA2533@odin.ac.hmc.edu> <2fd864e04111107487254fc10@mail.gmail.com> <20041111184040.GF54817@funkthat.com> X-Mailman-Approved-At: Fri, 12 Nov 2004 13:50:03 +0000 Subject: Re: Commitable R3000Z Patch! X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Astrodog List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2004 19:09:11 -0000 I think you actually need the device, for the keyboard on the machine to work. Its just the testing that breaks in this case. I'm not certain. Like I said, this has mostly come out of a desire on my part, to no longer maintain a fork that consists of 2 lines of code. --- Harrison Grundy On Thu, 11 Nov 2004 10:40:40 -0800, John-Mark Gurney wrote: > Astrodog wrote this message on Thu, Nov 11, 2004 at 09:48 -0600: > > Any hint will do, honestly. Just altering the patch to reflect the > > change will work. I'd like to automate it by detecting the mobile > > nforce3 chipsets, but I don't even know where to start with that yet. > > Any suggestions? > > Why don't you fix the real problem, which is that atkbdc_configure is > called from atkbd_configure even when the device is disabled? Why not > fix atkbd_configure to just bail out if the reousrce is disabled? > > > > > On Thu, 11 Nov 2004 07:31:14 -0800, Brooks Davis > > wrote: > > > On Thu, Nov 11, 2004 at 05:55:20AM -0800, Astrodog wrote: > > > > > > > > > > The patch is located at > > > > http://evogaming.il.us.tveps.net/~astrodog/atkbdc.patch testing was > > > > quite limited, but essentally, if you set hint.atkbd.0.disabled to 1, > > > > it disables the test. I suppose it could be renamed to any number of > > > > things, the code is a whole 2 lines, and is quite obvious. I'm gonna > > > > wait to see if it makes -CURRENT in the next day or so, so I don't end > > > > up with people grabbing ISOs from me if I don't have to (Snapshots > > > > servers are your freind). Automatic detection code to follow in the > > > > next day or so. This was tested on a Compaq 3004US, and it solved the > > > > reboot problem. I also tested on a dual opteron 240 machine, and when > > > > the hint is not set, it has no effect. I'm going to double-post to > > > > freebsd-current in hopes of getting it committed sooner, so all of us > > > > 3000Z-base laptop owners can have our fun with FreeBSD. > > > > > > Do you really have to use this hint? You're changing the meaning of > > > only one disabled flag which we're trying to make consistant. If that's > > > all you can use at that point, we'll live, but it seems ugly. > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." >