From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jan 13 08:40:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 447021065670 for ; Fri, 13 Jan 2012 08:40:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 31F6B8FC14 for ; Fri, 13 Jan 2012 08:40:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0D8e9FV029548 for ; Fri, 13 Jan 2012 08:40:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0D8e9kF029547; Fri, 13 Jan 2012 08:40:09 GMT (envelope-from gnats) Date: Fri, 13 Jan 2012 08:40:09 GMT Message-Id: <201201130840.q0D8e9kF029547@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Marc Werner Cc: Subject: Re: ports/164055: sysutils/zfs-periodic: Test if scrubbing is in process fails when using volume describtors instead of pools X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Marc Werner List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2012 08:40:10 -0000 The following reply was made to PR ports/164055; it has been noted by GNATS. From: Marc Werner To: bug-followup@FreeBSD.org, marc.werner@seemoo.tu-darmstadt.de Cc: Subject: Re: ports/164055: sysutils/zfs-periodic: Test if scrubbing is in process fails when using volume describtors instead of pools Date: Fri, 13 Jan 2012 09:18:25 +0100 Use this fix instead of the proposed one as the first suggestion throws = errors in some circumstances. # checks to see if there's a scrub in progress scrub_in_progress() { # This code was added to allow snapshotting of single volumes without = getting an error here scrub_pool=3D`echo $1 | awk '{split($0,a,"/"); print a[1]}'` if zpool status $scrub_pool | grep "scrub in progress" > /dev/null; = then return 0 else return 1 fi }