From owner-cvs-all@FreeBSD.ORG  Wed Apr 21 17:53:56 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 807DE16A4CF; Wed, 21 Apr 2004 17:53:56 -0700 (PDT)
Received: from smtp.des.no (flood.des.no [217.116.83.31])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D493643D5A; Wed, 21 Apr 2004 17:53:55 -0700 (PDT)
	(envelope-from des@des.no)
Received: by smtp.des.no (Pony Express, from userid 666)
	id 8E32A530D; Thu, 22 Apr 2004 02:53:54 +0200 (CEST)
Received: from dwp.des.no (des.no [80.203.228.37])
	by smtp.des.no (Pony Express) with ESMTP
	id 06898530A; Thu, 22 Apr 2004 02:53:48 +0200 (CEST)
Received: by dwp.des.no (Postfix, from userid 2602)
	id C226933C71; Thu, 22 Apr 2004 02:53:47 +0200 (CEST)
To: Darren Reed <darrenr@hub.freebsd.org>
References: <200404211527.i3LFRabS088245@repoman.freebsd.org>
	<20040421232445.GB60368@hub.freebsd.org>
	<6.0.1.1.1.20040422005919.03afaaa0@imap.sfu.ca>
	<20040422002143.GC60368@hub.freebsd.org>
From: des@des.no (=?iso-8859-1?q?Dag-Erling_Sm=F8rgrav?=)
Date: Thu, 22 Apr 2004 02:53:47 +0200
In-Reply-To: <20040422002143.GC60368@hub.freebsd.org> (Darren Reed's message
 of "Wed, 21 Apr 2004 17:21:43 -0700")
Message-ID: <xzpbrlkn884.fsf@dwp.des.no>
User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on flood.des.no
X-Spam-Level: 
X-Spam-Status: No, hits=0.0 required=5.0 tests=AWL autolearn=no version=2.63
cc: cvs-src@FreeBSD.org
cc: Luigi Rizzo <luigi@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: Colin Percival <colin.percival@wadham.ox.ac.uk>
Subject: Re: cvs commit: src/sys/net radix.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2004 00:53:56 -0000

Darren Reed <darrenr@hub.freebsd.org> writes:
> Changing variable names is required to make locking easier?
> Changing "x =3D *(u_char *)p" into "x =3D LEN(p)" makes locking easier?

Yes, if it allows the person doing the locking to better understand
the code.

DES
--=20
Dag-Erling Sm=F8rgrav - des@des.no