From nobody Fri Jul 31 11:56:23 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hBPfw1kSjz6mcyX for ; Fri, 31 Jul 2026 11:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hBPfw0RjLz3Fqs for ; Fri, 31 Jul 2026 11:56:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785498984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U5EeqGDt/PyQ+HgUXNmCQZ4KRs1rI3g0Zy4XxMcltEQ=; b=P8oq2Ukxg39e3rmOVe1Bw8YYcxdMPfwFDJwtwPmYZ71UIlFQKPdV8/zgiiQOg5QnNLdZ3m /RDOLB5EnDSaG/mCIqYeB8BzDBKYCW8y3J4fwFTb/36rau35DsJCl8GXiDv9SyGhAkXVHa GMCgmoxCbC3RXJ+/xwV4/67XJpuCxW63xwcqOfVH2UdhSkppoNeBggQfi/N6XCKhZjW/v0 DehM3ZMVQJc/NBqMy+O9CH2zG002CcqdKyTY1sHJVEwvzlphm8YsCdLM2gewwuGT6cLvkD 4vxjsgmzza5eNVdnoaXjYDfbX1ZKrPMzdw40CxziqgWHp/XuN1w/b4EYngaWMw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785498984; a=rsa-sha256; cv=none; b=SBg2xwfZvtUz3QOXoHekXoU/8nG8/JYZVTWfxpMgp5HqwK2TTNqhd5o+RvZ/j5GKNO0BW8 BDKtR8mJefpOhubpcDfABpiSauQmGpUO65zkNz5MY/uD7V2e02sMc53QL/nggDyJUD65zq fFCUi5D1/EjA17uky/bW3dmGo3T05GrJBeAPSL9scqKiAa4jf12R5hCeuWaVEgL9jFlJCG 02UcN58D3L/u5WkZhXK5GrH5w1yqyIeLrL3gWg0zhhPho4h7ynMFJ6axvNPtb7eKuauXjX 2jTPXUyHHdhqmcNawj7zN5aZX5esgoVMqUPXVg/j58iNvKUCQ/nAXWGJWnauEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785498984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=U5EeqGDt/PyQ+HgUXNmCQZ4KRs1rI3g0Zy4XxMcltEQ=; b=Zmnz6216JrAz4p9xKzY/YufjDFtLtfi9xAtcHOwTT6NvIRH6wz9WGsGmU86honbYWwPubr K6HLIF1f/sKtflaWgcFFJiiTFRf5CF2ZeVg/By9uGpebwGoDVXfYt+q6eBzO/lJMtUdk/+ KIFMNOK2XYGKXTMovmUdd5M93gWw7CAfmeyI2T/HIyVy6DgAKrK9jHCcsiMOpHgnIktmJs f+e6YE1y7vMwxJYbNyJ7LwLl+3jspq4J9XD9RvDRt90DBKUKIAZT15KEc7cr/IopdhbJaZ DGZBVHiNuZ49Dtyd/KeDv40IgTjCJO9+3JI6SwzlHRIP8SlgBiUxnvl102c0sQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hBPfv6KKvzy6L for ; Fri, 31 Jul 2026 11:56:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 40f7c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 31 Jul 2026 11:56:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: db2bf4553ce3 - main - ixgbe: fix host interface timeout detection List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: db2bf4553ce32fdcae00f6e7392a6c2010247dd6 Auto-Submitted: auto-generated Date: Fri, 31 Jul 2026 11:56:23 +0000 Message-Id: <6a6c8d67.40f7c.1a425520@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=db2bf4553ce32fdcae00f6e7392a6c2010247dd6 commit db2bf4553ce32fdcae00f6e7392a6c2010247dd6 Author: Kevin Bowling AuthorDate: 2026-07-28 11:21:14 +0000 Commit: Kevin Bowling CommitDate: 2026-07-31 11:55:39 +0000 ixgbe: fix host interface timeout detection The host-interface polling loop was scaled from milliseconds to microseconds, but its terminal test was left using the unscaled timeout. Completion at that intermediate iteration can be reported as a timeout, while actual expiry is not recognized and can accept stale status. Test against the scaled loop bound used by the polling loop. Fixes: f46d75c90f5f ("ixgbe: improve MDIO performance by reducing semaphore/IPC delays") MFC after: 1 week --- sys/dev/ixgbe/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/ixgbe_common.c b/sys/dev/ixgbe/ixgbe_common.c index 0b6bf728f25e..ab763595f0b5 100644 --- a/sys/dev/ixgbe/ixgbe_common.c +++ b/sys/dev/ixgbe/ixgbe_common.c @@ -4646,7 +4646,7 @@ s32 ixgbe_hic_unlocked(struct ixgbe_hw *hw, u32 *buffer, u32 length, return IXGBE_SUCCESS; /* Check command completion */ - if ((timeout && i == timeout) || + if ((timeout && i == timeout * 1000) || !(IXGBE_READ_REG(hw, IXGBE_HICR) & IXGBE_HICR_SV)) { ERROR_REPORT1(IXGBE_ERROR_CAUTION, "Command has failed with no status valid.\n");