Date: Sat, 2 Feb 2002 21:09:32 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Nik Clayton <nik@FreeBSD.org> Cc: "David E. O'Brien" <obrien@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/lib/libc/gen disklabel.c err.c Message-ID: <20020202205847.D4120-100000@gamplex.bde.org> In-Reply-To: <20020202083852.M82801@clan.nothing-going-on.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2 Feb 2002, Nik Clayton wrote: > On Sat, Feb 02, 2002 at 01:46:26AM +1100, Bruce Evans wrote: > > I may summarily back out any removals of __P that either add style bugs > > or change the object file. > > You don't think it would be more helpful to fix the problems, or raise > them on the mailing lists so that other people can learn from them? It doesn't seem to work. My request to not change all the function headers at the same time as removing __P(()) was ignored. The main changes to object files so far were in sh. the code that emits C code was changed to not support emitting K&R code. The main style bugs are in ed/cbc.c. Some not-completely-banal comments that were attached to parameter names were removed; some were moved to a not so good place (old-style function headers provided a better place to put the comments), and at least one was not moved, leaving it misformatted. Most of the changes were done right so I didn't back out any :-). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020202205847.D4120-100000>