From owner-cvs-all Thu Mar 6 9:12:53 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 91F0E37B401; Thu, 6 Mar 2003 09:12:51 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id A517543FA3; Thu, 6 Mar 2003 09:12:49 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.8/8.12.3) with ESMTP id h26HClA7038420; Thu, 6 Mar 2003 10:12:48 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 06 Mar 2003 10:12:19 -0700 (MST) Message-Id: <20030306.101219.02055932.imp@bsdimp.com> To: ru@FreeBSD.org Cc: tjr@FreeBSD.org, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netsmb smb_dev.c smb_subr.h src/sys/fs/smbfs smbfs_node.h smbfs_vfsops.c smbfs_vnops.c From: "M. Warner Losh" In-Reply-To: <20030306153455.GD55489@sunbay.com> References: <200303061038.h26AcJWL095388@repoman.freebsd.org> <20030306153455.GD55489@sunbay.com> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20030306153455.GD55489@sunbay.com> Ruslan Ermilov writes: : Thanks. I think that __FreeBSD_version ifdefs inside the src/ : are generally bogus and should be removed, unless the code is : kept the same (by the maintainer) for different branches. That's why I use them :-) Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message