From nobody Wed Feb 5 19:42:32 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yp9cS3PFJz5mGBv; Wed, 05 Feb 2025 19:42:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yp9cS2s0zz3rYM; Wed, 05 Feb 2025 19:42:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738784552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6u6WAnfhD2yHSRIvINiVrmNPgAWZ3UnzM/wUh/5N8oI=; b=ppWjnfV3XLCXRhLX6NCIK9i11eMjBlquIUyMS1DrdajOMNrsiiY3PUOieuMQ9R7a0uJhGs nxuyWujCP0C681s8ZsMzj+JZBxTAhWaSaNLQsWXnYQCQOUsPdoe2+4Ok8as2XDJmR9+ouv 3kQsLpMQ7p3GZK0Ew5FsfKtgWjq37SwEAVs8zh4vjGrB2N7MLsFYIYQzWqJcB/h5F8QApM EJbGj6FPOtH4v2vZ4JEySOrTvyMt473+A+jY8S43eBZWe8+CQA6d3pAmM651MtBa2Bgi04 8kOaL99SNmkdO6oqVcRmKOQRbDLmHbLakLs/AdRbMM4OSQ8iAI2FbwhUom5j5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738784552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6u6WAnfhD2yHSRIvINiVrmNPgAWZ3UnzM/wUh/5N8oI=; b=wFyvyJeQ5mxeI136rv/Uvqu9VC/oZzF5XhjP6p6UnxxGOA8+8QDPAfeqH5LkAqns29Esum eW37yZZ0WDSht2wSX1gnTNtpRY71mxMWgA9DxNoRWdepvF1kT9ZoJ0JThswqI+qpoRtakX 1xxuoYUdmwyVGRpDx4W0ySAOWgap2zQ6yvK2xswkQM/3YX5mPPneiEgMBInKYaJQbXnBcJ SPlniwt6c11DQ73AlwIk4yP7zwpvflgzc/3NZMhAw0Op+1A1nnCZ/O0MCPGFCc8XVuMbX3 GtC6MAOVOKxn/ZF2cb+ovxt1gi7UXJagkvHMFANDvp4xyNs2MyMhBMk1toX85Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738784552; a=rsa-sha256; cv=none; b=UAY2XNM7vdhTcHgPSy4plyedWkYj24B0oKPaWjfCyIUifsoY9qQsXcAWlfCIqX9AuQ6Ffm NHB1FQhkBthQZGblwrR/mLzOvhgRlcu2kfpBCKVtjuBWZGiJeNMmANClq15EWU1YMz0bBK aRiSkajHookvcc26ch5aToBMhvo231XE7IG+2MCfGRt09kNoNvYgWb0AbLd3p+2I8BryhL 4LHtOaA8eZK9nVqRI3C3ZYmD80V/I6PBCsva/DnHk4Xn6IvN/HSCfYouIFexdrwVUrxr7q 7Sc9TUNknTrDWjOoa3BFSfCLpmp0qd+WD78CJ/uIHJyHPVPiK5wb0mAyu9g0Cw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Yp9cS2RY8z15P1; Wed, 05 Feb 2025 19:42:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 515JgWJQ067562; Wed, 5 Feb 2025 19:42:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 515JgWnQ067559; Wed, 5 Feb 2025 19:42:32 GMT (envelope-from git) Date: Wed, 5 Feb 2025 19:42:32 GMT Message-Id: <202502051942.515JgWnQ067559@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 0da0b392e2e4 - stable/14 - TCP RACK, BBR: ensure return value is always ininitialized List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0da0b392e2e44a3333753c1e238e9ed706f8af9b Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=0da0b392e2e44a3333753c1e238e9ed706f8af9b commit 0da0b392e2e44a3333753c1e238e9ed706f8af9b Author: Michael Tuexen AuthorDate: 2024-12-30 15:02:43 +0000 Commit: Michael Tuexen CommitDate: 2025-02-05 08:42:51 +0000 TCP RACK, BBR: ensure return value is always ininitialized Do not return an uninitialized value from ctf_do_queued_segments() in case no packets are actually processed (all are skipped). Reviewed by: rrs CID: 1523774 Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D48217 (cherry picked from commit b5739c8b12226c791bc8e7a4ac6e48965333509a) --- sys/netinet/tcp_stacks/rack_bbr_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/netinet/tcp_stacks/rack_bbr_common.c b/sys/netinet/tcp_stacks/rack_bbr_common.c index b218f449475f..9fd1817192c9 100644 --- a/sys/netinet/tcp_stacks/rack_bbr_common.c +++ b/sys/netinet/tcp_stacks/rack_bbr_common.c @@ -478,7 +478,7 @@ skipped_pkt: if (no_vn == 0) { CURVNET_RESTORE(); } - return(retval); + return (0); } int