From owner-freebsd-net@freebsd.org Wed Oct 24 00:33:20 2018 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 282EF1039921; Wed, 24 Oct 2018 00:33:20 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABD9C79AA3; Wed, 24 Oct 2018 00:33:19 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w9O0XFXN025274; Tue, 23 Oct 2018 17:33:15 -0700 (PDT) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w9O0XEep025273; Tue, 23 Oct 2018 17:33:14 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201810240033.w9O0XEep025273@pdx.rh.CN85.dnsmgr.net> Subject: Re: FCP-0101: Deprecating most 10/100 Ethernet drivers In-Reply-To: To: Warner Losh Date: Tue, 23 Oct 2018 17:33:14 -0700 (PDT) CC: Brooks Davis , FreeBSD-STABLE Mailing List , Ian Lepore , FreeBSD Net , "Julian H. Stacey" , Michelle Sullivan , "freebsd-arch@freebsd.org" , freebsd-fcp@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2018 00:33:20 -0000 > On Tue, Oct 23, 2018 at 6:02 PM Rodney W. Grimes < > freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: ... deleted un relavent text ... > > > > > > Brooks, > > > > > > Is there a public revised version of FCP-0101 that > > reflects the > > > > > > feedback which is what core is voting on? > > > > > > > > > > > > > > > > Its on github, just like it's been the whole time for anybody to see, > > > > > submit pull requests against and track: > > > > > > > > I have no gh account, desires no gh account, so have no way to > > > > submit a change request other than through direct email to > > > > brooks or another gh user. This is fundementally flawed. > > > > > > > > > https://github.com/freebsd/fcp/blob/master/fcp-0101.md > > > > > > > > Thank you for the link, I had looked at it before MeetBSD, > > > > which did not have most of the recent changes done "a day ago". > > > > > > > > Isnt this document now in a frozen state while core reviews/votes? > > > > > > I sent it to a vote at c224c67557297d7cba909ad008542cb60980cc6b only > > > to notice a bug in table rendering. I submitted a pull request fix > > > that and a missing word which was merged since neither was material. I > > > suppose they could have waited or been skipped, but there's no value in > > > the FCP process being bound by the sort of pointless rigidity that led > > > to -DPOSIX_MISTAKE in every libc compile line. > > > > The FCP process itself is unclear on this point, > > I think this should be clarified. > > > > It is much more clear on post approval: > > Changes after acceptance > > > > FCPs may need revision after they have been moved into the > > accepted state. In such cases, the author SHOULD update the > > FCP to reflect the final conclusions. > > If the changes are major, the FCP SHOULD be withdrawn > > and restarted. > > > > Good point Rod. While common sense suggests that trivial changes during the > voting should be allowed for editorial purposes (eg fix grammar mistakes, > table rendering etc), it's better to spell that out so there's no confusion. Agreed. > > diff --git a/fcp-0000.md b/fcp-0000.md > index b4fe0f3..c8cc6f7 100644 > --- a/fcp-0000.md > +++ b/fcp-0000.md > @@ -144,7 +144,10 @@ When the discussion of a change has come to a suitable > and acceptable close it > SHOULD be updated to the `vote` state. > > At this time the FreeBSD Core Team will vote on the subject of the FCP. The > -result of vote moves the FCP into the `accepted` or `rejected` state. > +result of vote moves the FCP into the `accepted` or `rejected` state. The > +core team MAY make minor edits to the FCP to correct minor mistakes. Core > +MAY return the proposal to the submitter if there are major problems that > +need to be addressed. This allows and clarifies that core may modify it, it does not address if the author/submitter can modify it. > > FCPs in the `accepted` state can be updated and corrected. > See the "Changes after acceptance" section for more information. > > Normally I'd submit that as a pull request, but since I know you don't use > github, I thought I'd present it here to see if this answers your concerns > before doing so. I thank you very much for that consideration, -- Rod Grimes rgrimes@freebsd.org