From owner-svn-ports-head@FreeBSD.ORG Tue Sep 9 21:33:27 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8822967A for ; Tue, 9 Sep 2014 21:33:27 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6978CC04 for ; Tue, 9 Sep 2014 21:33:27 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s89LXRej083243 for ; Tue, 9 Sep 2014 21:33:27 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s89LXRG6083239 for svn-ports-head@freebsd.org; Tue, 9 Sep 2014 21:33:27 GMT (envelope-from bdrewery) Received: (qmail 20027 invoked from network); 9 Sep 2014 16:33:25 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 9 Sep 2014 16:33:25 -0500 Message-ID: <540F7221.2040001@FreeBSD.org> Date: Tue, 09 Sep 2014 16:33:21 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: John Marino , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r367578 - head/Mk References: <201409071718.s87HIdWP096355@svn.freebsd.org> <540F71FA.2090202@FreeBSD.org> In-Reply-To: <540F71FA.2090202@FreeBSD.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="InExdbLmBB0uWhU4vwuxbQc4sTAqWmcS1" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 21:33:27 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --InExdbLmBB0uWhU4vwuxbQc4sTAqWmcS1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/9/2014 4:32 PM, Bryan Drewery wrote: > On 9/7/2014 12:18 PM, John Marino wrote: >> Author: marino >> Date: Sun Sep 7 17:18:39 2014 >> New Revision: 367578 >> URL: http://svnweb.freebsd.org/changeset/ports/367578 >> QAT: https://qat.redports.org/buildarchive/r367578/ >> >> Log: >> bsd.port.mk: Fix typo found in EXTRA_PATCHES handling >> =20 >> PR: 193432 >> Reported by: ian@ >> Approved by: portmgr (implicit, obvious, just-fix-it) >=20 > This blanket does not apply to bsd.port.mk. The spirit was against > maintainer lock of ports. Most bsd.port.mk changes require exp-runs. I do agree it is an obvious fix, I'm just saying the "just fix it" does not generally apply. >=20 >> >> Modified: >> head/Mk/bsd.port.mk >> >> Modified: head/Mk/bsd.port.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/Mk/bsd.port.mk Sun Sep 7 17:09:50 2014 (r367577) >> +++ head/Mk/bsd.port.mk Sun Sep 7 17:18:39 2014 (r367578) >> @@ -3390,7 +3390,7 @@ do-patch: >> *) patch_file=3D$$i ;; \ >> esac ; \ >> ${ECHO_MSG} "=3D=3D=3D> Applying extra patch $$patch_file" ; \ >> - case $$patfh_file in \ >> + case $$patch_file in \ >> *.Z|*.gz) ${GZCAT} $$patch_file ;; \ >> *.bz2) ${BZCAT} $$patch_file ;; \ >> *.xz) ${XZCAT} $$patch_file ;; \ >> >=20 >=20 --=20 Regards, Bryan Drewery --InExdbLmBB0uWhU4vwuxbQc4sTAqWmcS1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUD3IhAAoJEDXXcbtuRpfPhCAIALlWig6aM0NdeQ7Nj8jlnuq7 4vH5xv1cvF/Rz+3WaMnm2RkhYs23YqAh4fTIeNr8PdKHhl6ubeLvKlICdnB041Y+ YXKUBk78a+YAtRrwbVb+zujCE8XpAMRT99Vc5zg8Z/mivXXzsVPCxIJOOQjKTHtp 23wIOzT1zpqe/1+FrmO8u7wjG0Her/VPZdDAuqmpxeQuyuEI8QD6x3GJ5UicWpC6 s/6G/8YxfhVmZTqmfUGSA0HDGehQDpxcYPDOUZmVr2SmlAMcEaf1XPMDS7dh0ln/ mK9l4k6K5r0VZPiq5AWheElVWNAnAbGuY29uMoZ4BPYljPwk9iVksB9fNxz/a/o= =jvtX -----END PGP SIGNATURE----- --InExdbLmBB0uWhU4vwuxbQc4sTAqWmcS1--