From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 21:29:49 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EBF1AE8D; Thu, 23 Jan 2014 21:29:49 +0000 (UTC) Received: from mail-we0-x22f.google.com (mail-we0-x22f.google.com [IPv6:2a00:1450:400c:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 377C51DB2; Thu, 23 Jan 2014 21:29:49 +0000 (UTC) Received: by mail-we0-f175.google.com with SMTP id p61so1864888wes.34 for ; Thu, 23 Jan 2014 13:29:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=2AnP4g5ln+rOClkn6td59ynojsCo5KOyV+cviNNVDS4=; b=0TpkZvKo5xndGK3+HYAxuTF1gGe78snFo2Yl3wR4kYRIUyR4RlrWqUofOPkrwy0Qof BBxJ6H6oAq/Smr+qo/+5jpX/KC51o/MJ9yh2MLXZE8wqINnHyG+hGLhwuOxvhHTfs3jP 67P3zZ8RAHyikolrcw5rl2Ir+eEFcoZ0MPto0TQINC30fld7lBO43irbZGdzWxDdrvG/ OANL1ODhg5KX58wF3kU04u/HQBvCJN1DpE428eSsP1l4HVb/No7YyIUputuj8nrDlvQT f5rgB/3uJP0LZvsHiXd4uBecPL8SK1FwgdhRKV1FVPABaZOZva44d+O8dseHhkR3hbJy LW+g== MIME-Version: 1.0 X-Received: by 10.194.187.101 with SMTP id fr5mr5937wjc.76.1390512587732; Thu, 23 Jan 2014 13:29:47 -0800 (PST) Sender: asomers@gmail.com Received: by 10.194.22.35 with HTTP; Thu, 23 Jan 2014 13:29:47 -0800 (PST) In-Reply-To: <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <4DB8E40F-6D7B-41A9-A0FA-B2E241E9A180@gmail.com> Date: Thu, 23 Jan 2014 14:29:47 -0700 X-Google-Sender-Auth: e5K0vOWBjtw8UpQk2UtwqfAxKr4 Message-ID: Subject: Re: Makefile.inc1.patch From: Alan Somers To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" , Brooks Davis , "Simon J. Gerraty" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 21:29:50 -0000 On Thu, Jan 23, 2014 at 2:23 PM, Garrett Cooper wro= te: > On Jan 23, 2014, at 1:11 PM, Alan Somers wrote: > >> In that case, I'm missing something. I can't find any makefiles that >> reference MK_ATF or a related variable. What is the effect of setting >> WITH_ATF ? >> >> -Alan > > NO_TESTS forces WITHOUT_TESTS to be set. So, if I set NO_TESTS in= the various build steps it will force ATF to not be built. For that reason= (and that reason alone) I reintroduced WITH_ATF just for Makefile.inc1 (bu= t you could replace it with something else like WITH_ATF_LIBS, etc, if the = naming is too confusing). > Thanks! > -Garrett I get that much, but what I don't understand is what direct affect WITH_ATF has. Did you forget to reintroduce a ".if defined(MK_ATF)" in some other file? -Alan