From owner-svn-src-head@FreeBSD.ORG  Mon Nov 14 18:02:42 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C12A3106566B;
	Mon, 14 Nov 2011 18:02:42 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101])
	by mx1.freebsd.org (Postfix) with ESMTP id 30EE18FC15;
	Mon, 14 Nov 2011 18:02:35 +0000 (UTC)
Received: from zim.MIT.EDU (localhost [127.0.0.1])
	by zim.MIT.EDU (8.14.5/8.14.2) with ESMTP id pAEI2Zch058370;
	Mon, 14 Nov 2011 13:02:35 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by zim.MIT.EDU (8.14.5/8.14.2/Submit) id pAEI2ZlL058369;
	Mon, 14 Nov 2011 13:02:35 -0500 (EST) (envelope-from das@FreeBSD.ORG)
Date: Mon, 14 Nov 2011 13:02:35 -0500
From: David Schultz <das@FreeBSD.ORG>
To: Dimitry Andric <dim@FreeBSD.ORG>
Message-ID: <20111114180235.GA58284@zim.MIT.EDU>
Mail-Followup-To: Dimitry Andric <dim@freebsd.org>,
	Stefan Farfeleder <stefanf@freebsd.org>,
	David Chisnall <theraven@freebsd.org>, src-committers@freebsd.org,
	svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201111131618.pADGIm2n099696@svn.freebsd.org>
	<20111114082129.GA1596@mole.fafoe.narf.at>
	<4EC0E6C2.4010509@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4EC0E6C2.4010509@FreeBSD.org>
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	Stefan Farfeleder <stefanf@FreeBSD.ORG>,
	David Chisnall <theraven@FreeBSD.ORG>, src-committers@FreeBSD.ORG
Subject: Re: svn commit: r227487 - head/include
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Nov 2011 18:02:42 -0000

On Mon, Nov 14, 2011, Dimitry Andric wrote:
> On 2011-11-14 09:21, Stefan Farfeleder wrote:
> > On Sun, Nov 13, 2011 at 04:18:48PM +0000, David Chisnall wrote:
> >> Author: theraven
> >> Date: Sun Nov 13 16:18:48 2011
> >> New Revision: 227487
> >> URL: http://svn.freebsd.org/changeset/base/227487
> >>
> >> Log:
> >>   The spec says that FILE must be defined in wchar.h, but it wasn't.  It
> >>   is now.  Also hide some macros in C++ mode that will break C++
> >>   namespaced calls.
> >>   
> >>   Approved by:	dim (mentor)
> > 
> > I think this change is wrong. Whic spec are you referring to? C99
> > defines FILE only in 7.19.1#2 (stdio.h). In other headers FILE is used
> > as parameter type for functions but that does not mean it is exported to
> > user space.
> 
> http://pubs.opengroup.org/onlinepubs/007908799/xsh/wchar.h.html

It's a niggling detail, but that's an extension to the C standard,
so properly speaking, it belongs in an
  #if __POSIX_VISIBLE >= 200809 || XSI_VISIBLE
(or something like that).  The formals were struct __sFILE *
instead of FILE * for that reason -- see r103177.

P.S. You're looking at a very old version of POSIX.  Check out:
     http://pubs.opengroup.org/onlinepubs/9699919799/