From nobody Wed Aug 6 15:32:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bxvRv5W1lz63rv4; Wed, 06 Aug 2025 15:32:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bxvRv474hz47d7; Wed, 06 Aug 2025 15:32:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754494347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CoTYhSrykCK75bC/s/CvHz0dIfnMbvfzNVwau9wq9r0=; b=kwy0AzRym+3HoiCSopFKeKW22ILtXzEerAN9/Z1zofjHUZNN52NCC7vKt9NMVbr/O6LbhP 8+DXfaH/iR46US9fS47dLxOXO/9aPMCxgHjxusdBL3EZEefb9FRILqqlYgkjZUHgcPyZl6 1K99W1BDfN6w9V2Ronthtoy5k12Hov/PvDA+z0P86dy5O89RwbmSwl4ZQyVXKRr40Df1d8 BQjia1Axqul9zYgexv4j6g2aD+Cz9n2shoRsMug/2+QWScdPoOdrAtSozd28KKZscM70Hh Rf/Dq6CHUqp+wBsa3DWX0E1jmlFE32K1tGFlzIjgcrw8IZj5FCTo5pmpPdJC3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754494347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CoTYhSrykCK75bC/s/CvHz0dIfnMbvfzNVwau9wq9r0=; b=gkRNYyS4GrvihOwpbFhMJKQhKLVPGF9VhCBRns3V1rP/dqVzhdzXAP1wht9rzGflnbcHdN PCWK/rbpqVfXfla6Sa1sJZM52fYNNrMLBRW0HXPqeDCe0lcaMRNwAvw/e/2QnFyKUqE6cA cEL7s1D7fLSiv2sUoYIsYpNSlyJuSgVL8UfzVjURSYayKTBoBDXYk1vrk1qTYNHgBTjNsi uSsd4tT5MkiFQbBVLxPDLXopFM1udPW9hIxgGCKi85Cl4cEQBN1fOxL3daPZSKDIzIBFG+ IctgbjEba/LUDRVvXru+Fk0xHoEElmGPQOSvucicD6dVZK09xpPvYcUx9QQtjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754494347; a=rsa-sha256; cv=none; b=QrW/gRRi6J2X6oH5JJt3uvORzrgfT8lHugJLLsbsrvh0E9lRlViaCUvqNNfSaALLoNEkMU yfYm1skocSs0dCQVBNSZsqQAnqpW9By3RTXCmk5Jui1rR8VfzfAZpmVd2oY3Un40EAiF4e +B/fz/I/kBXwuLV0GWu8gFxNplx3oWjtl/229lED2hB0p7l5Sc6UJ7400yHLqa3YhvGhE4 KxOwJDjh5gB23IaG2dzPIFWUrEJUdytXGW/Oc4oB4pcJ6wZbHoYkBE9RmeAj/fvafj4QRH jsQmkEUO/NQH4qHa4hWcwDrrPFiMFhOtxXjGnWkvGOGQYqiuCzBiSCr7Tro5Jg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bxvRv11VXzBF5; Wed, 06 Aug 2025 15:32:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 576FWR7I048995; Wed, 6 Aug 2025 15:32:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 576FWRQG048992; Wed, 6 Aug 2025 15:32:27 GMT (envelope-from git) Date: Wed, 6 Aug 2025 15:32:27 GMT Message-Id: <202508061532.576FWRQG048992@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: f318186deb3e - stable/13 - netlink: Fully clear parser state between messages List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f318186deb3ef3b90104e8372563e80c9358183e Auto-Submitted: auto-generated The branch stable/13 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=f318186deb3ef3b90104e8372563e80c9358183e commit f318186deb3ef3b90104e8372563e80c9358183e Author: Dag-Erling Smørgrav AuthorDate: 2025-07-31 10:06:47 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-08-06 13:52:14 +0000 netlink: Fully clear parser state between messages Failing to reset the cookie between messages can lead to an attempt to interpret a zeroed buffer as a struct nlattr, causing a length calculation to underflow, resulting in a memcpy() call where the length exceeds the actual size of the buffer. MFC after: 1 week PR: 283797 Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D51634 (cherry picked from commit a8d90e32133b77a49c2551f22e59f72d65293b64) --- sys/netlink/netlink_io.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netlink/netlink_io.c b/sys/netlink/netlink_io.c index d33a3ace9e36..baa7e3350caf 100644 --- a/sys/netlink/netlink_io.c +++ b/sys/netlink/netlink_io.c @@ -454,6 +454,7 @@ static void npt_clear(struct nl_pstate *npt) { lb_clear(&npt->lb); + npt->cookie = NULL; npt->error = 0; npt->err_msg = NULL; npt->err_off = 0;