From nobody Thu Oct 2 12:15:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ccrN00qx9z69jsD; Thu, 02 Oct 2025 12:15:12 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ccrN00By6z3rW9; Thu, 02 Oct 2025 12:15:12 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759407312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3glQiS/jZOTuSQDTkawP+I8oOcaLKqs78cVcEtUtiAc=; b=l5w2awgYSDHqmw5kCQgfLVaTGwODFcxEAz75C4AHBR1MMFS8xUtowQh1yHDyUH3MmnDFGd +7WlXeEfEiw2+Y9UwRtuu7+dYilbiIr9ATl9PibhCs42JFaf7o7EpL3/Uj8d6dKoADI27v aGKJQg+M7oET6i7eyHiEBYb9H7AU50lKypmQwKldbICmE2TVuNXFUj3qmuchgPBVC6lvpa qGUJj4sBiK8y4WDbbgSGEu0hX+qcQXMsFjlSevZNlTO5Z6GujSR9OuJ6yzYGNpl4ck6CiA yRw46aDxRG0Ic2RNsBObE1D90CaGKAIzLUJggod3r85OYu84opow6DM0QOs4jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759407312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3glQiS/jZOTuSQDTkawP+I8oOcaLKqs78cVcEtUtiAc=; b=gXtESydi1X0QGNalwuIju70NMWHiJ00hfyzn7HgM1//Jt4D7u7NLq9K1xkFqzXgv9zpiV1 qfN9ifE6Jow2hLhRuAE7KSLETZtJJmRhTcFDT0CyTg45ItM/B9Y64SAS33jaQr29ZB/VCB V1nc452bE7ZbJZLQ5BYux5cGvRXlH/pAV1vGGb5ZuGXUaFDxJ9JU1cRn8XRhb2RTqhWQA+ /ILY8KzekSFl85B4200muD31g8F04WpbZM2UbZR1n/4fb4MWRyZciD/3P2dznm+ucOQss+ SdOSyBQ9JHsELSYvutpJIw6WvbVwmD8jeCJYUFJz4lfOO9ldzB4qL7zPu/Dtlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759407312; a=rsa-sha256; cv=none; b=dFOsTjUzQdQC+4vZ67Rb3xMLAdrX3A7afP+kuCvkJtoo/lnMyglcfWcjqO5v87IiRC8IMI Jbq5rszBxEhBL5JKvbgWRBLRcrLI0GDgTclsgp79AgRQTzgIwVI6kVsiiosTDHkby5z7Le VwFBPwES/g4t6f0N0xbQtqvyf8itlLS0yWt0YnrcISuc6FcRqP/r0vYaaZojPpjfBQRAi1 rKNW0lY2qf5V3yBiTUXkx21jffiXMx99+nzjib5ziquE30PSeznODJ8osRdyCAT9ORIwL3 DaEKdD5vDHmHEImc7+VtCMqYyp+gSdc+O+vUyNs9RQQhAq8UnaYZ7vzUvqNFhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2804:f1c:3e:b01:c1f1:ca24:3d73:8d59] (unknown [IPv6:2804:f1c:3e:b01:c1f1:ca24:3d73:8d59]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ccrMz1NYxzx3M; Thu, 02 Oct 2025 12:15:11 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: Date: Thu, 2 Oct 2025 09:15:05 -0300 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 08f06aa1b4fb - main - vfs: retire the VCALL macro To: Mateusz Guzik Cc: Mateusz Guzik , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202509270401.58R41A7b014829__21824.1523530864$1758945716$gmane$org@gitrepo.freebsd.org> <85c486e1-6fde-4f4a-b4ce-bfbec7bb693f@FreeBSD.org> Content-Language: en-US From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/10/25 16:01, Mateusz Guzik wrote: > On Wed, Oct 1, 2025 at 8:35 PM Renato Botelho wrote: >> >> On 27/09/25 01:01, Mateusz Guzik wrote: >>> The branch main has been updated by mjg: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=08f06aa1b4fb6db0d8beb3e1c328b1c1adbec13a >>> >>> commit 08f06aa1b4fb6db0d8beb3e1c328b1c1adbec13a >>> Author: Mateusz Guzik >>> AuthorDate: 2025-09-27 02:01:32 +0000 >>> Commit: Mateusz Guzik >>> CommitDate: 2025-09-27 04:00:59 +0000 >>> >>> vfs: retire the VCALL macro >>> >>> There is precisely one place using it and even that should probably go >>> away. >>> --- >>> sys/fs/nullfs/null_vnops.c | 2 +- >>> sys/sys/vnode.h | 5 ----- >>> 2 files changed, 1 insertion(+), 6 deletions(-) >>> >>> diff --git a/sys/fs/nullfs/null_vnops.c b/sys/fs/nullfs/null_vnops.c >>> index 74c1a8f3acb6..ba29b0485326 100644 >>> --- a/sys/fs/nullfs/null_vnops.c >>> +++ b/sys/fs/nullfs/null_vnops.c >>> @@ -306,7 +306,7 @@ null_bypass(struct vop_generic_args *ap) >>> * with the modified argument structure. >>> */ >>> if (vps_p[0] != NULL && *vps_p[0] != NULL) { >>> - error = VCALL(ap); >>> + error = ap->a_desc->vdesc_call(ap); >>> } else { >>> printf("null_bypass: no map for %s\n", descp->vdesc_name); >>> error = EINVAL; >>> diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h >>> index 6ef9bbec9446..fcfb8716fc52 100644 >>> --- a/sys/sys/vnode.h >>> +++ b/sys/sys/vnode.h >>> @@ -594,11 +594,6 @@ void assert_vop_unlocked(struct vnode *vp, const char *str); >>> >>> #endif /* INVARIANTS */ >>> >>> -/* >>> - * This call works for vnodes in the kernel. >>> - */ >>> -#define VCALL(c) ((c)->a_desc->vdesc_call(c)) >>> - >>> #define DOINGASYNC(vp) \ >>> (((vp)->v_mount->mnt_kern_flag & MNTK_ASYNC) != 0 && \ >>> ((curthread->td_pflags & TDP_SYNCIO) == 0)) >>> >>> >> >> FYI, this commit along with retirement of NULLVP and VREF broke >> open-vm-kmod build on current. I wonder if there are move ports that >> could be affected. >> > > I could bump __freebsd_version for it, but what you can do is simply > not use the old stuff on any supported branch. I'm working on open-vm-* upgrade to 13.0.5 and will get it fixed, just sent a FYI because there could be more broken ports around. -- Renato Botelho