From owner-cvs-all Thu Jan 16 10:38: 9 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1F87537B406 for ; Thu, 16 Jan 2003 10:38:08 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 8B40B43F6D for ; Thu, 16 Jan 2003 10:38:06 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 47150 invoked by uid 1000); 16 Jan 2003 18:38:07 -0000 Date: Thu, 16 Jan 2003 10:38:07 -0800 (PST) From: Nate Lawson To: Bruce Evans Cc: Hidetoshi Shimokawa , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h In-Reply-To: <20030117052637.I3675-100000@gamplex.bde.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 17 Jan 2003, Bruce Evans wrote: > On Thu, 16 Jan 2003, Nate Lawson wrote: > > > > - contigfree((void *)(uintptr_t)sc->fc.sid_buf, > > > - OHCI_SIDSIZE, M_DEVBUF); > > > + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); > > > > Unnecessary casts (there are others). > > Er, these casts seem to be necessary to break warnings from -Wcast-qual. > sid_buf has type "volatile u_int32_t *". Yes, I've had to discard volatile also (when dealing with freeing an aio_buf). I'm interested why it can't be cast directly to (void *). Why the indirection through unitptr_t? -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message