From owner-svn-ports-head@freebsd.org Tue Jun 23 23:41:27 2020 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B91B033CE2F; Tue, 23 Jun 2020 23:41:27 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49s2qB3mvQz4J5f; Tue, 23 Jun 2020 23:41:26 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-ej1-f42.google.com with SMTP id rk21so534513ejb.2; Tue, 23 Jun 2020 16:41:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=rYz88TqVoEI8gMckH7bbBL4s0+hf3/nejtYPuBLdv9I=; b=sTCp8ZJ2qrs5LS5wW6RfvlHKpj9hxm7MsQdJI0F7qX/Bf4pVkxJwOjc/2e2VtV6LfA n2HCljodiSKswPALqtQI5jnipLTZnkh23AYBObYp59ImqPV2GfNv3CpYT5BL2sVeiRuL I1GIMW/Q2F4T4OeUl/gWO1HV1EwEGfO5KkIUyjFjobgvgDJ3tJGf2kA+xIHtO1HRudgy hnNqD5WGfQ1UrmGLcskjJo7orkWSUZZEsg474blTmkw/ArMjI2ThLpHPzltsZaCrV9qh Soa0pBHMQUYwxD5JidnQE+M/QgqGLAciG3wd6R236a9znHyzhJxkD7fzFmF86kGjWMsB gv3Q== X-Gm-Message-State: AOAM530d15ASok9FRUT3NX/Hl5Lwt7akehrbKnwnQQF7dRhOO7/+Ke0r JTDGh+MZC3IknBnwmucsZQ0K3msp X-Google-Smtp-Source: ABdhPJyyg1lTmo1HTM8baw409RfMfjfQJ8zEjlL4rBf32Gx05S+L5gOcEBtb/gcPFm2iiHVheZg+tg== X-Received: by 2002:a17:906:57da:: with SMTP id u26mr5563539ejr.157.1592955684694; Tue, 23 Jun 2020 16:41:24 -0700 (PDT) Received: from ?IPv6:2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8? ([2a02:8109:98c0:1bc0:5e5f:67ff:fef4:ffd8]) by smtp.gmail.com with ESMTPSA id o8sm6189437ejj.102.2020.06.23.16.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 16:41:24 -0700 (PDT) Subject: Re: svn commit: r539975 - in head/x11-themes: . slim-freebsd-dark-theme To: Adam Weinberger Cc: ports-committers , svn-ports-all , svn-ports-head References: <202006231225.05NCPGsL001130@repo.freebsd.org> <93fdbb58-3e28-3417-cd23-c07e168cd2f2@FreeBSD.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> Message-ID: Date: Wed, 24 Jun 2020 01:41:20 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 49s2qB3mvQz4J5f X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-2.72 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-0.96)[-0.958]; RWL_MAILSPIKE_GOOD(0.00)[209.85.218.42:from]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.83)[-0.828]; RCVD_IN_DNSWL_NONE(0.00)[209.85.218.42:from]; NEURAL_HAM_MEDIUM(-0.93)[-0.932]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 23:41:27 -0000 On 6/24/20 12:43 AM, Adam Weinberger wrote: > On Tue, Jun 23, 2020 at 4:40 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: >> On 6/24/20 12:12 AM, Adam Weinberger wrote: >>> On Tue, Jun 23, 2020 at 6:25 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: >>>> URL: https://svnweb.freebsd.org/changeset/ports/539975 >>>> >>>> Log: >>>> New port: x11-themes/slim-freebsd-dark-theme >> [...] >>> Shouldn't this port have a RUN_DEPENDS on x11/slim? >> I've checked similar ports and they do not depend on x11/slim. > Interesting. Should they? You know far more about the use-case here > than I do so I definitely defer to your judgment, but the description > makes it sound like x11/xlim is required to make it go. It is required, of course. It is a theme after all ;) I have a feeling that it would not help the end user to have RUN_DEPENDS here. In fact, I can imagine that new SLiM users might want to install a theme first, see if they like it based on the included screenshots, and then decide to download x11/slim. When it comes to old SLiM users, they have x11/slim installed anyway. Hmm, but the more I think about it, the more I feel it is not how we manage ports. We should at least have a SLIM option defined and then set SLIM_RUN_DEPENDS. But then who would really use it? Maybe we should just set RUN_DEPENDS=slim:x11/slim. Eh. What do you think, Adam? Cheers, Mateusz