From nobody Sun May 21 22:55:58 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QPbXq1pXsz4Cb9B for ; Sun, 21 May 2023 22:56:11 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QPbXq0D02z3ClC for ; Sun, 21 May 2023 22:56:11 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3f41dceb9c9so35357525e9.3 for ; Sun, 21 May 2023 15:56:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684709769; x=1687301769; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6Wsuem8UfpPbX9TXOTJntE4Y4yzuzt5h1wLg0ziuY0s=; b=WfVDglYdrcwbJhBdHMMFvU8ix5aIwh1aa78wc1NI2CRIEd6JxpjIjZfm1kULifDlEj 06YXEZUDaVWRmRuaT+TPbSvOV+yPm80xNH4sJWSjy0CuP90R6RqjvKd2QPGsnmALvtk5 2ESZ0VeOaWI8Aq8D/TDl4z3lT0CUEEa3uoXx2guOyTqbBlho82ao2ZCBSJgOOtbpMCc1 7TKAxdg0wiSIhQaiDwatf5o92HRvTqTnm+LumZttWinyrdMAue7Jg3gxceUZs0PZXWgx 4AjPCgz3GOfSrBoUG8zdDeeWOGknmtMaPsBKLwvmQgPQ8EEDyV3fY8g1PpDmSmSGQWaH GXHg== X-Gm-Message-State: AC+VfDzKnOQyDY4f72LyaOLc+kQWJkRQYmoCXYyjuPMOewjz4Ere2UF+ 3UVc/Y+FflPyn9/mDkjf34Yh8A== X-Google-Smtp-Source: ACHHUZ7eC5/yUL/W/5TP+I/YlOF8Gi8SOjk4Kt1KdR6XSlzAmiJgaeXYPXwTCBpM+uKoGP7YpM54EA== X-Received: by 2002:adf:ee91:0:b0:309:509f:a7f0 with SMTP id b17-20020adfee91000000b00309509fa7f0mr6317193wro.44.1684709769552; Sun, 21 May 2023 15:56:09 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id f5-20020a5d4dc5000000b002fe13ec49fasm5716484wru.98.2023.05.21.15.56.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2023 15:56:09 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Subject: Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body. From: Jessica Clarke In-Reply-To: <6ed6216b-d237-fbe0-e2b8-960c53a53562@freebsd.org> Date: Sun, 21 May 2023 23:55:58 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <7482D20A-86B1-434B-A817-AECEF6D5828B@freebsd.org> References: <202305211621.34LGLsup059861@gitrepo.freebsd.org> <54EF67D8-2A79-4EAB-8EFB-232F14FFE792@freebsd.org> <21c9532e-4ca7-a7fe-1ff6-07a94cbad6ab@freebsd.org> <3066464F-E4C6-4B84-ADFF-E578AFAFE622@freebsd.org> <26465813-3B51-4E52-9E9D-F93A0F2AF6BD@freebsd.org> <2BF2F7CF-82E6-4D98-800D-C35D7C29E948@freebsd.org> <8f46512a-f086-6da0-2fdd-3ffc89f4dfdd@freebsd.org> <1787C08C-AD82-48EC-92E2-49360B1AB8B0@freebsd.org> <6ed6216b-d237-fbe0-e2b8-960c53a53562@freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3731.500.231) X-Rspamd-Queue-Id: 4QPbXq0D02z3ClC X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 21 May 2023, at 23:51, Hans Petter Selasky = wrote: >=20 > On 5/22/23 00:32, Jessica Clarke wrote: >> Once again I will remind you that the FreeBSD tree is not somewhere = for you to play around with experiments. Changes should be properly = justified. >=20 > Hi Jess, >=20 > This is FreeBSD-current / main and my change is perfectly fine as = such. Sorry. Just because it=E2=80=99s not stable/* or releng/* doesn=E2=80=99t mean = you can=E2=80=99t do whatever you want. > It is not my problem why GIT has to use cryptographic hashes, so that = commit messages cannot be changed without forced pushing. I don=E2=80=99t even want to start up that debate again. > The justification for this change should be clear from our e-mail = exchange. Your attempt at one is. A justification that I wholeheartedly disagree = with, and that you yourself have undermined by stating multiple ways in = which you would make it unnecessary. For the fifth time: revert this patch. Today. Not at some point in the = future of your choice when you feel like it. Jess