From owner-p4-projects@FreeBSD.ORG Mon Mar 20 19:14:45 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 5C40916A424; Mon, 20 Mar 2006 19:14:45 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8A2316A400; Mon, 20 Mar 2006 19:14:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 768E443D4C; Mon, 20 Mar 2006 19:14:43 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k2KJEf6f002247; Mon, 20 Mar 2006 14:14:42 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Todd Miller Date: Mon, 20 Mar 2006 14:06:41 -0500 User-Agent: KMail/1.9.1 References: <200603201525.k2KFPkaO012910@repoman.freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603201406.43861.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1345/Mon Mar 20 07:03:16 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.6 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Todd Miller , Perforce Change Reviews Subject: Re: PERFORCE change 93627 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2006 19:14:45 -0000 On Monday 20 March 2006 10:50, Todd Miller wrote: > > On Mar 20, 2006, at 3:25 PM, Todd Miller wrote: > > > http://perforce.freebsd.org/chv.cgi?CH=93627 > > > > Change 93627 by millert@millert_p3 on 2006/03/20 15:25:46 > > > > In fdcopy() set newfdp->fd_freefile after the first loop > > over fdp instead of the loop over newfdp. This means we > > never enter fdused() with fd_freefile == -1. It also fixes > > a bug when fdp->fd_lastfile == -1. Previously, if > > fdp->fd_lastfile was -1 newfdp->fd_freefile would get set > > to 1 instead of 0 since newfdp->fd_lastfile is initialized > > to 0 and newfdp->fd_freefile will not have been set in the > > first loop (which doesn't run at all in this case). > > It's not clear why newfdp->fd_freefile is -1 at this point. > > That last line should have read: > It's not clear why newfdp->fd_lastfile is -1 at this point. csjp@ just fixed this in FreeBSD head. I also had the change to move the setting of cmask up earlier to avoid an extra lock/unlock pair in one of my p4 branches as well. :) You'll probably want to make sure you're changes are in sync with what csjp@ just committed to make the merge in the future less exciting. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org