From owner-freebsd-current Sat Nov 30 0:10:16 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CBE137B401 for ; Sat, 30 Nov 2002 00:10:14 -0800 (PST) Received: from spider.deepcore.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 681A343EB2 for ; Sat, 30 Nov 2002 00:10:02 -0800 (PST) (envelope-from sos@spider.deepcore.dk) Received: (from sos@localhost) by spider.deepcore.dk (8.12.5/8.12.6) id gAU89x5l051007; Sat, 30 Nov 2002 09:09:59 +0100 (CET) (envelope-from sos) From: Soeren Schmidt Message-Id: <200211300809.gAU89x5l051007@spider.deepcore.dk> Subject: Re: ATA patches for PC98 - Please test! In-Reply-To: <20021130.151419.112534450.nyan@jp.FreeBSD.org> To: Takahashi Yoshihiro Date: Sat, 30 Nov 2002 09:09:59 +0100 (CET) Cc: current@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL98b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG It seems Takahashi Yoshihiro wrote: > In article <200211292044.gATKipVT018982@spider.deepcore.dk> > Soeren Schmidt writes: > > > I'm trying to get this into 5.0 (I know its late, but life's tough) > > > > This brings ATA support to the PC98 arch will all bells and whistles. > > > > --- sys/conf/files 28 Nov 2002 01:17:48 -0000 1.738 > > +++ sys/conf/files 28 Nov 2002 20:01:52 -0000 > > @@ -290,6 +290,7 @@ > > dev/asr/asr.c optional asr pci > > dev/ata/ata-all.c optional ata > > dev/ata/ata-isa.c optional ata isa > > +dev/ata/ata-cbus.c optional ata pc98 > > This should be 'dev/ata/ata-cbus.c optional ata isa' and moved into > files.pc98. Well, this gives the exact same behavior, but I'm not religious about it :) > > --- sys/pc98/conf/GENERIC 31 Oct 2002 12:14:05 -0000 1.220 > > +++ sys/pc98/conf/GENERIC 27 Nov 2002 10:06:46 -0000 > > @@ -78,11 +78,18 @@ > > # Floppy drives > > device fdc > > > > -# IDE controller and disks > > -device wdc 1 > > +# ATA and ATAPI devices > > +device ata > > +device atadisk # ATA disk drives > > +device atapicd # ATAPI CDROM drives > > +device atapifd # ATAPI floppy drives > > +device atapist # ATAPI tape drives > > +options ATA_STATIC_ID # Static device numbering > > > > +# IDE controller and disks > > +#device wdc 1 > > # ATAPI devices on wdc > > -device wcd 1 #IDE CD-ROM > > +#device wcd 1 #IDE CD-ROM > > #device wfd 1 #IDE Floppy (e.g. LS-120) > > #device wst 1 #IDE Tape (e.g. Travan) > > What about GENERIC.hints? Good point, it should also be in /boot/loader/device.hints. > > --- /dev/null Fri Nov 29 21:35:31 2002 > > +++ sys/dev/ata/ata-cbus.c Thu Oct 31 19:32:25 2002 > > @@ -0,0 +1,270 @@ > > +/*- > > + * Copyright (c) 2002 Søren Schmidt > > + * All rights reserved. > > The original author of this file is IMAI Takeshi. Where is his > copyright? Excuse me ? I wrote this file, I looked in other pc98 drivers in the tree for hints and style however, if that demands that I put other copyrights in the file let me know... > Where is vaild bank checking code? I'm not sure what you mean here, please explain... > And, what about all atapi-* changes? These changes are needed to > support buggy atapi devices. Are you refering to the old ATAPI CDROM's that think they are disk/floppy devices ? I must remind you that this is NOT based on the PC98 ATA patches floating around, that patch is way to intrusive, and demands way too many changes to the generic code, which IMHO are not nessesary.... -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message