From owner-cvs-all Thu Oct 17 11:55:50 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E853D37B401; Thu, 17 Oct 2002 11:55:46 -0700 (PDT) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 36B0743E6E; Thu, 17 Oct 2002 11:55:45 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id EAA11275; Fri, 18 Oct 2002 04:55:42 +1000 Date: Fri, 18 Oct 2002 05:06:24 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Mitsuru IWASAKI Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/i386/isa clock.c In-Reply-To: <200210171355.g9HDtjBt054703@repoman.freebsd.org> Message-ID: <20021018050254.U12092-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 17 Oct 2002, Mitsuru IWASAKI wrote: > iwasaki 2002/10/17 06:55:44 PDT > > Modified files: > sys/i386/isa clock.c > Log: > 1. Fix a comment. Locking _is_ needed (but not done). > 2. Update a comment. We now restore much more than RTC updates and > interrupts. > 3. Order change. Stop interrupts by writing to RTC_STATUSB, > ... > 4. Don't stop the clock (RTCB_HALT). We only program some control bits > and don't want to stop the clock. > 5. (Not really related.) Add caveats to the comment about timer_restore(). > The update is non-atomic since locking is not done. > > On locking: > 6. rtcin() and writertc() are locked() adequately by splhigh() in RELENG_4, > but this locking is null in -current. > 7. Doing things in the correct order in (3) combined with (6) is probably > enough locking for rtcrestore() in RELENG_4. In -current, the > writertc()'s race with rtcintr() unless the BIOS disables RTC interrupts. > > Submitted by: bde (including commit message) > MFC after: 1 week Thanks. The commit message is a bit too verbose. Please summarize it and adjust the comments for the MFC (most of the locking problems are only in -current). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message