From owner-svn-ports-head@freebsd.org Thu Dec 7 08:10:58 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1716EA0A1A; Thu, 7 Dec 2017 08:10:58 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from mail.ptrcrt.ch (gahr.cloud.tilaa.com [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DE2407B5F4; Thu, 7 Dec 2017 08:10:57 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from ptrcrt.ch (mail.ptrcrt.ch [192.168.1.1]) by mail.ptrcrt.ch (OpenSMTPD) with ESMTPS id 3a608fd1 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Thu, 7 Dec 2017 08:10:56 +0000 (UTC) Date: Thu, 7 Dec 2017 08:10:56 +0000 From: Pietro Cerutti To: Joe Marcus Clarke Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r447981 - in head/ports-mgmt/portlint: . src Message-ID: <20171207081055.xtssqrp5okethfeu@ptrcrt.ch> Reply-To: Pietro Cerutti References: <201708151243.v7FChEAF043279@repo.freebsd.org> <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ntonfb6yk5jxaf73" Content-Disposition: inline In-Reply-To: <20171207080421.qijzbigqkbfbezqe@ptrcrt.ch> X-PGP-Key: fp="DA6D E106 A5B8 54B8 5DD8 6D49 ADD0 D38E A192 089E"; id="0xA192089E"; get=; get=; get=; get= OpenPGP: id=A192089E; url=https://gahr.ch/pgp/0xADD0D38EA192089E.txt; url=https://keybase.io/gahr/key.asc User-Agent: NeoMutt/20171027-245-1d0c7d X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 08:10:59 -0000 --ntonfb6yk5jxaf73 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Dec 7 17 08:04, Pietro Cerutti wrote: > On Aug 15 17 12:43, Joe Marcus Clarke wrote: > > Author: marcus > > Date: Tue Aug 15 12:43:14 2017 > > New Revision: 447981 > > URL: https://svnweb.freebsd.org/changeset/ports/447981 > >=20 > > Log: > > Update to 2.17.12. >=20 > > @@ -3400,6 +3437,11 @@ sub abspathname { > > =20 > > if ($pre =3D~ /MASTER_SITE_SUBDIR/) { > > # MASTER_SITE_SUBDIR lines are ok. > > + $i =3D ''; > > + } > > + if ($s =3D~ /\$\{[^}]*?$i/) { > > + # If we're inside a make variable, we probably do not have > > + # an absolute path. > > $i =3D ''; > > } > > } > >=20 >=20 > Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1 )= =20 > <-- HERE / at /usr/local/bin/portlint line 3443. >=20 > I think the ? doesn't belong there. No, my analysis was wrong. It's about the contents of the $i variable.=20 Here's why. You can reproduce by portlint -AC in net-im/openfire. i is /var/log/openfire WARN: Makefile: possible use of absolute pathname "/var/log/openfire". i is /var/db/openfire WARN: Makefile: possible use of absolute pathname "/var/db/openfire". i is /dev/null 2>&1 ) Unmatched ) in regex; marked by <-- HERE in m/\$\{[^}]*?/dev/null 2>&1 )=20 <-- HERE / at /usr/local/bin/portlint line 3444. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org --ntonfb6yk5jxaf73 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAloo948uFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII ntpkEACeE66+w6L4Uf7/RTg5xmLeRgRhcpKIMGKSEfq4N6N90hMKPEkfZeUpskGM s7PBkB+ea5o8pMGAyzdwb2T4/eNzjZYbTe+NFskA7vaPPLW5n8sow/RZtPlOBXZI X4YMsxwO62QbvZfJp7NfPfNXMAQiKsuda8/Ui4LgsUedgE9XKJ2TB2oHYDL2lgxu JpQUAKgnH6aw+COYSSkHjXcWRAIK6VEbUGCJIWPsShvHVsRWmezU+1G0rrAnJjzo eVUoH0ayF2pavtcPopMlWifdqdV1WnCM4YWfAkgjLHYTdeGx2mq6yrTfoRZbO3zC AvY4AocOuEboEdBMX6mv4m476iFvlwIK7v/yO9uO+buoJ1NqhN1UcTiGvtGDSCbO Nth2epmLGbQ7PMjMAc04r+UYRqoA11bQKqzCUsqSal+6UmQM9GiEjukppeDLbIzA LDJuJjXj+EnfOTZpf1nTWf1WLpNz6mLPNxYNF/0h6oXnjNvQtIzPJDV3PKlg8X5R uYKlHwS7Mv1qwufdKQEvpzYtbKFhapnvIoU8M0HsQH8YYnFIN7HNolITFvWU//mJ fGP1v6scfyCF1ul0xnQYIdbNoWYCV2UuEUH5qD4a3rplvDZrj3JJiRtXa8LDXKX8 9Tf1BiPO3P44oSPcsfVlkblxQPWhUKFTsZrfmEfAHhCeAk6i3w== =qRbU -----END PGP SIGNATURE----- --ntonfb6yk5jxaf73--