Date: Fri, 7 Nov 2014 10:26:47 -0500 From: Ryan Steinmetz <zi@FreeBSD.org> To: marino@freebsd.org Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r372261 - in head/devel/ding-libs: . files Message-ID: <20141107152647.GB76739@exodus.zi0r.com> In-Reply-To: <545CE318.6000000@marino.st> References: <201411071333.sA7DXdtR038743@svn.freebsd.org> <545CCF05.70609@marino.st> <20141107151238.GA76739@exodus.zi0r.com> <545CE318.6000000@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On (11/07/14 16:19), John Marino wrote:
>On 11/7/2014 16:12, Ryan Steinmetz wrote:
>> On (11/07/14 14:54), John Marino wrote:
>>> On 11/7/2014 14:33, Ryan Steinmetz wrote:
>>>> +LIBS+= -L${LOCALBASE}/lib -liconv -lintl
>>>
>>> shouldn't that be:
>>> LIBS+= -L${LOCALBASE}/lib ${ICONVLIB} -lintl
>>>
>>> or something like that?
>>
>> Not unless you can tell me what defines ICONVLIB. :)
>>
>
>Mk/Uses/iconv.mk
>
>setting it unconditionally is normally wrong. iconv.mk defines it when
>it's needed.
>
Ah, I was grepping for ICONVLIB, not ICONV_LIB. Will pass this onto the
maintainer for testing.
-r
>John
--
Ryan Steinmetz
PGP: 9079 51A3 34EF 0CD4 F228 EDC6 1EF8 BA6B D028 46D7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141107152647.GB76739>