From owner-cvs-src@FreeBSD.ORG Tue Mar 20 00:21:20 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 46F7D16A402; Tue, 20 Mar 2007 00:21:20 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailout2.pacific.net.au (mailout2-3.pacific.net.au [61.8.2.226]) by mx1.freebsd.org (Postfix) with ESMTP id 1045813C4B0; Tue, 20 Mar 2007 00:21:20 +0000 (UTC) (envelope-from bde@zeta.org.au) Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id 507CC109814; Tue, 20 Mar 2007 11:21:14 +1100 (EST) Received: from besplex.bde.org (katana.zip.com.au [61.8.7.246]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id AA81527414; Tue, 20 Mar 2007 11:21:17 +1100 (EST) Date: Tue, 20 Mar 2007 11:21:15 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Jung-uk Kim In-Reply-To: <200703192317.l2JNHd59062213@repoman.freebsd.org> Message-ID: <20070320111650.C6064@besplex.bde.org> References: <200703192317.l2JNHd59062213@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/mii brgphy.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2007 00:21:20 -0000 On Mon, 19 Mar 2007, Jung-uk Kim wrote: > jkim 2007-03-19 23:17:39 UTC > > FreeBSD src repository > > Modified files: > sys/dev/mii brgphy.c > Log: > Revert couple of changes from 1.51 and 1.52. Reading link status with BMSR > is okay for most of the chipsets but BCM5701 PHY does not seem to like it. > Set media to IFM_NONE if link is not up instead of the previous value. > > Reported by: Goran Lowkrantz (goran dot lowkrantz at ismobile dot com) > > Revision Changes Path > 1.66 +12 -14 src/sys/dev/mii/brgphy.c Does this fix the problem that reading the link status causes input errors? oleg@ has a large patch which avoids this problem by not always reading the link status in bge_tick(). I use a simpler verion of this. Bruce