From owner-freebsd-current@freebsd.org Wed May 27 01:52:35 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C745D2FAC2A for ; Wed, 27 May 2020 01:52:35 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49Wv3R3WNMz4MJp; Wed, 27 May 2020 01:52:35 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qk1-x72b.google.com with SMTP id c185so8822171qke.7; Tue, 26 May 2020 18:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Enf2MCEAcPXJJF3I1oRj9g0lzMtfXSQSlnu04ZFTopc=; b=cjBMrWqfX6E8v3WqbMd57gThAM16uuTj1GSS38OmJ2c+9VfXzJYjtbwcPirUw8IckN 82lwOEsBunjAj/DMK6P6qiiT2taUqxnrtSBukVzu30kvgiHZL2fnVJb2GfOt+lRia7O/ PD5qEk8wPj+X1nnqX0CWGIq3qGv65w1gugDrIjb8cLZdFov8Ax2s3I6/jHXcfLMAWUbv fiPDW3OHvRXfN9q6sZtCZxVY3ALj0P47aelcd10whx3vZoG8ZAJHVQetr9d1Jd+xkVgy ibJ9qyNFG5fJtDZ2uGnYFALjKho8MtpDiwpWqfJIWUyFUvlpHsUFw48AELz0Ha+f8cVc 5tfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Enf2MCEAcPXJJF3I1oRj9g0lzMtfXSQSlnu04ZFTopc=; b=M9xLgG3p1vdASiLDtPiloB/XDghXxCGQpCfAPLpT+m9iBSoFVi3oGrChkqH5FjwaCz S7rmyuQ6utePt6uFHyZauefMln/hNQaaoRNFngy6m1zsPgRAOJpPvoKJBehh5cH9SPRp bUJ9MF7g9+GLKBmJv9t5L14BsshZyNVPWiv0pUUVn+PQJacu0HzoY4U8TtPbEs2mglmQ /b/G8YaIDTS7lCadYJZzYCEqlFmBnsqAFkZ9e9nvhM8hjHJZwZsuzpQ74eeWLVf3yebV Lj/LUZt2dcawDUE8ygXcRsx4d6S3aOptJ8/zwbpEztQChithOw+806666UD+i4L13PN1 ImWA== X-Gm-Message-State: AOAM532Jp1MeAW2SacbjGmUSAGNKjTeaVIo5Mkdqpw5BkjOwt4CM1kSR +ShlVUSVbVGKT1dPfnjCiNgPDmgow1GhiHzQOf5vQg== X-Google-Smtp-Source: ABdhPJxeVxVW+HHLlc7zXuRCaFlfhvSCuRe4iHa6B7cXbLN+KjCJEJgsi/5CQRLByANkdwfnkdw82xWYhrhEkSnwW3c= X-Received: by 2002:a05:620a:c0f:: with SMTP id l15mr1872113qki.183.1590544353453; Tue, 26 May 2020 18:52:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Adrian Chadd Date: Tue, 26 May 2020 18:52:21 -0700 Message-ID: Subject: Re: iflib and options RSS is a no go for igbX To: Matthew Macy Cc: freebsd-current Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49Wv3R3WNMz4MJp X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2020 01:52:35 -0000 On Tue, 26 May 2020 at 17:01, Matthew Macy wrote: > > > > > I can go setup my second PC this week (I have PTO!) and go see if I > > have any PCIe igb hardware here. I /think/ I do but it's fibre. > > The RSS compile time option used to be disabled in part because of > this. The drivers had working RSS that relied on packet receipt before > setting flowid. And it should also work fine if you don't compile in the RSS option. The reason it's annoying is when you do RSS + PCBGROUPS; as I said in the ena review the challenge was getting traffic into the right pcbgroup inpcb list and that isn't doable if you're waiting for hardware flowid first. Honestly I think we should rename it to something else besides RSS, cause it's more like PCBGROUPS + microsoft RSS. It's not very well named right now and I think it's confusing tf out a lot of people. -adrian