Date: Thu, 22 Feb 2007 15:36:11 GMT From: Oleg Lomaka<oleg.lomaka@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/109436: net/rdesktop segmentation fault Message-ID: <200702221536.l1MFaBNr086564@www.freebsd.org> Resent-Message-ID: <200702221540.l1MFe7xQ006892@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 109436
>Category: ports
>Synopsis: net/rdesktop segmentation fault
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Feb 22 15:40:07 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator: Oleg Lomaka
>Release: RELENG_6
>Organization:
>Environment:
6.2-STABLE FreeBSD 6.2-STABLE #6: Wed Jan 17 10:22:07 EET 2007 i386
>Description:
net/rdesktop segmentation fault in file xclip.c line 210
function lf2crlf, on line '*o++ = '\0';'
>How-To-Repeat:
Occasionally when work with VMWare on remote Windows workstation
>Fix:
Patch attached with submission follows:
--- xclip.c.orig Mon Aug 7 14:45:43 2006
+++ xclip.c Thu Feb 22 17:24:58 2007
@@ -207,7 +207,7 @@
*length = o - result;
/* Convenience */
- *o++ = '\0';
+ if (*length > 0) *o++ = '\0';
return result;
}
@@ -288,6 +288,10 @@
{
DEBUG_CLIPBOARD(("xclip_send_data_with_convert: target=%s, size=%u\n",
XGetAtomName(g_display, target), (unsigned) source_size));
+ if (source == 0)
+ {
+ return False;
+ }
#ifdef USE_UNICODE_CLIPBOARD
if (target == format_string_atom ||
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702221536.l1MFaBNr086564>