From nobody Fri Aug 1 23:13:02 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bv1vg0D60z63FHn; Fri, 01 Aug 2025 23:13:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bv1vf4xkRz3VcS; Fri, 01 Aug 2025 23:13:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754089982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hkwk+T0752hv1UMod0OntV6OI4G1WUu4AkKkUIPzSyQ=; b=aUA3DhVCK76XHg6sKFEFkdX5pNcobLwqmRz3v+Hn+VU45xrJhDXSNibaWiI/qCNb0gwmcG oi4+Jn6G30iHw8ZvxIInqu7xMaHw9Q47+/tFLJ+QjroKZn26e/+vHIP8zU87wFFFe20X94 alrjcK/Ix+MTcTy2x7EXc4Ayt/0ms05evArP+iojqrUNeNn9KxC+nF5KTiPtkcSPnGolJz w4jmPa2fTCJSZRslfmC+lGizhf7mA5vc7NdAq3zrAod5gGgzGU+Vv6kID5W5Px4eBp9aJt V8iqhSyI0GsY/PfseMFJ+5Scpt9/egyKCWbBFpL+Wx/0hMA4KmqZyDdNO1+enw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754089982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Hkwk+T0752hv1UMod0OntV6OI4G1WUu4AkKkUIPzSyQ=; b=ixF54j0s1g9/lTXRohPsT4rYLkTURSyIjft7hMSfglDFXihWA4lX7XCZ0TSqkq0yt091pL A9tal/DlsO5RNt1inLDPEupVl0C2nwB+uts1995izfZOZaLeyRr7sYgmkTkX2D51pj26Mq Ov1/S7bl4Bz9MpGUUNCLg6145PFIvD3OS/qh/zT6jJRPmz91CKyih/GmuPlhUpi8742z1W 8dIdjodb6ZNij762BXARafjs/DzLq6aIrO/Jueb6iXXxHW1QDxfau66/c/F+4UTS084ZPZ agYTgZwd4U2l4XPEZ27jnFxVhwM748oEBAX32ykpuEctisj72H2aIWiy+EUP8w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754089982; a=rsa-sha256; cv=none; b=YFskxIXFr47bZkGVB0pPnpcbL7BJEYC0anjgxy+WLFhviEnBkET9g47pBN9rNjA4pDqf8m 26Qvs8h3WfD+MG0Vt8Csmy0MdvQjmi8jK+rw7LUOOzCEbWRFraYnXJeKIwMm9xXNWJiagt Rjlih4mSrBfzU77hQSwLd4IHq7RGs+hmss0bGIBi4Ekau2SRhq6t6abIvxfDGrZOAspHdK eRElo5Ytzi6lseMhlpFvHh39KiYJJ1wNaS5z9AUgy7P9Z9rQTxPs7jDEb8dQWejnTiWqNC +VeJ//oNmWimdepRUsz0tj+Gi63qsUNzJvU7NTlFePiSNXVb7EUYmmxneYlcFw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bv1vf4YCTz17D7; Fri, 01 Aug 2025 23:13:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 571ND2kh053521; Fri, 1 Aug 2025 23:13:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 571ND2Nu053518; Fri, 1 Aug 2025 23:13:02 GMT (envelope-from git) Date: Fri, 1 Aug 2025 23:13:02 GMT Message-Id: <202508012313.571ND2Nu053518@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling =?utf-8?Q?Sm=C3=B8rgrav?= Subject: git: 2bd157bc732a - main - libc: Deprecate readdir_r() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2bd157bc732a1939cb71314e48de6118b91e0ad0 Auto-Submitted: auto-generated The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=2bd157bc732a1939cb71314e48de6118b91e0ad0 commit 2bd157bc732a1939cb71314e48de6118b91e0ad0 Author: Dag-Erling Smørgrav AuthorDate: 2025-08-01 23:11:31 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-08-01 23:11:56 +0000 libc: Deprecate readdir_r() This function was never safe to use. We marked it deprecated in the manual page in 2016, and it is marked obsolete in POSIX 2024. Add a linker warning and annotate the prototype. Sponsored by: Klara, Inc. Reviewed by: imp, markj Differential Revision: https://reviews.freebsd.org/D51681 --- include/dirent.h | 3 ++- lib/libc/gen/readdir.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/dirent.h b/include/dirent.h index dff0e8675722..7fcdceb10b23 100644 --- a/include/dirent.h +++ b/include/dirent.h @@ -116,7 +116,8 @@ DIR *fdopendir(int); struct dirent * readdir(DIR *); #if __POSIX_VISIBLE >= 199506 || __XSI_VISIBLE >= 500 -int readdir_r(DIR *, struct dirent *, struct dirent **); +int readdir_r(DIR *, struct dirent *, struct dirent **) + __deprecated1("Does not take variable {NAME_MAX} into account"); #endif void rewinddir(DIR *); #if __POSIX_VISIBLE >= 200809 || __XSI_VISIBLE >= 700 diff --git a/lib/libc/gen/readdir.c b/lib/libc/gen/readdir.c index b70102954df1..94d2b2e8d877 100644 --- a/lib/libc/gen/readdir.c +++ b/lib/libc/gen/readdir.c @@ -134,3 +134,5 @@ __readdir_r(DIR *dirp, struct dirent *entry, struct dirent **result) } __strong_reference(__readdir_r, readdir_r); +__warn_references(readdir_r, + "warning: this program uses readdir_r(), which is unsafe.");