From nobody Fri Sep 5 19:37:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cJRSP4vMcz66J05; Fri, 05 Sep 2025 19:37:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cJRSP3sYqz3T3W; Fri, 05 Sep 2025 19:37:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757101029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMj49MHqraz04hN/JC08vHqMaqBooAWTcj0+hvoy1y8=; b=RLa/YX32dacs74oXIZAbyEuF6/rGgnJJJ6jqP3lSmDVrXF9ZiQ9m42lJ5/+0X6bnFcCnoZ Reao92Cse3+55b7hsXU/TXfmJqpHGVQyg5juZqdnivhJDC5CSLBpwxVK64GfK9wCYwdI31 ai5B3wkxhAYTZvneqPU4/48MN/YVc+qDfFVU8+S1DSrTVvAqyJztsM+y3w8UaOxTTBPBG9 8oPytXkjmJf63YeRq6YSyYGsPc0+JbJYa+oJbBbVC8fvl8fQ5+dHxjC2vJrEMuD66VGOPJ Zk61VEsH+VmuiJ+7TZDWrPUPTWc09ZonlEJYNEZ5TcMiOc9DLNnipVgndkabhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757101029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wMj49MHqraz04hN/JC08vHqMaqBooAWTcj0+hvoy1y8=; b=a2nJVlLzFMw+1fL3ryUxjgneosqLBtwIpc2xYXmXlbMMUClkc40ECJEvSoJRvh6G6xf2vH D63hH54gdzLlR2+/i2QQWNmHNS/6BpLuqVUOZn7ZAZHndl86+C676MDgSwHLi+Ils/6Lmq 2Upebyv/T2xeGREEBgv6ZHKdtTKmwr6O12GWH68WKFru8BfNlY3OnxvSs3XwWlbqAZQkPv 3tHcw4fT47N0Np9XdrhUQ4okA9cJRtFrg8yOFDozopE0M7Fefi6ErKeCw0uUXbST8ZccW/ USnk2c1Sqgeq3SeBjv3fph31Rtqk6KLnilSl5hvmR9eSOKGqcyqUuVbH8XrSbQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757101029; a=rsa-sha256; cv=none; b=C4cM96+TSmKQxHg+ORsomEDf2C2B6Bd17mRGNHEEWmW3xTTnU7X37TzM19IhnbTNNSBdEH PY+0tlZ3NEHU4an5H2ky1N5hS4zbwG1Hpf49B45HAdojTg1Ji5QI0B9lYot80TrJFm6yKp 8fXRbWVW0ynw2INe2jrtgx4qGdmATMv8onkDb8vhIihRbe28vOaULJib2NYd1nXwAlZMne niMPsJzMniXy0dBPoM2drUGUvIKoU43aqndXJpEqRbG4HxPnLSkoGEAxeqiZgMvt5+swG2 Oqs0o3t9+5SqzIG4evh+6KkK3Rci8TPN0pACjeESJxpsk43t3kMZ++y2UwHfdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:1df4:287d:7dcd:6a55] (unknown [IPv6:2601:5c0:4202:5670:1df4:287d:7dcd:6a55]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cJRSP1m0Yz16sP; Fri, 05 Sep 2025 19:37:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 5 Sep 2025 15:37:07 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: a930cc8bad64 - main - GEOM_UNION: Should free sc in g_union_ctl_create when error happened. Content-Language: en-US To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202509051842.585IgHAr096237@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202509051842.585IgHAr096237@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/5/25 14:42, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a930cc8bad644039cfcfa5ff7c6fe3e8548aa9ae > > commit a930cc8bad644039cfcfa5ff7c6fe3e8548aa9ae > Author: Wuyang Chung > AuthorDate: 2025-09-02 06:23:26 +0000 > Commit: Warner Losh > CommitDate: 2025-09-05 18:42:20 +0000 > > GEOM_UNION: Should free sc in g_union_ctl_create when error happened. > > Signed-off-by: Wuyang Chung > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1835 > --- > sys/geom/union/g_union.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sys/geom/union/g_union.c b/sys/geom/union/g_union.c > index 9734fc1bcfe3..0701e76db671 100644 > --- a/sys/geom/union/g_union.c > +++ b/sys/geom/union/g_union.c > @@ -358,6 +358,7 @@ fail2: > fail1: > g_destroy_consumer(lowercp); > g_destroy_provider(newpp); > + g_free(sc); > g_destroy_geom(gp); > } Hmm, as markj@ noted in the review, this also needs an `rw_destroy`. -- John Baldwin